Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2989263002: [Gardening Tool] Allow filtering groups by names in current_summary.dart (Closed)

Created:
3 years, 4 months ago by Dmitry Stefantsov
Modified:
3 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Gardening Tool] Allow filtering groups by names in current_summary.dart R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b5aeeb5b258e218d82a9f83fb500d6310d6899cf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M tools/gardening/bin/current_summary.dart View 2 chunks +20 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Stefantsov
As a first step in enhancing current_summary.dart I added this simple filtering technique. Now I'm ...
3 years, 4 months ago (2017-08-02 12:52:51 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2989263002/diff/1/tools/gardening/bin/current_summary.dart File tools/gardening/bin/current_summary.dart (right): https://codereview.chromium.org/2989263002/diff/1/tools/gardening/bin/current_summary.dart#newcode47 tools/gardening/bin/current_summary.dart:47: help: "Restricts the build groups\n" Remove '\n' - ...
3 years, 4 months ago (2017-08-02 13:39:08 UTC) #3
Dmitry Stefantsov
Thank you for the review, Johnni! Please, find my responses below. https://codereview.chromium.org/2989263002/diff/1/tools/gardening/bin/current_summary.dart File tools/gardening/bin/current_summary.dart (right): ...
3 years, 4 months ago (2017-08-02 14:48:40 UTC) #4
Dmitry Stefantsov
3 years, 4 months ago (2017-08-02 14:49:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5aeeb5b258e218d82a9f83fb500d6310d6899cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698