Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2989243003: Resynthesize values of final fields of classes with const constructors. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize values of final fields of classes with const constructors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4ea75e9f8e0ffa75e2b117ec8b1e9d0ef00c662a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/kernel/resynthesize.dart View 7 chunks +11 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-08-02 17:18:24 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-02 17:21:45 UTC) #2
scheglov
3 years, 4 months ago (2017-08-02 17:26:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ea75e9f8e0ffa75e2b117ec8b1e9d0ef00c662a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698