Pass additional options in incremental setup

Pass additional options in incremental setup

With this, we can infer the .packages file on disk.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d66294cfe241c4fc250d23f6481cf2df69ff3e7a

[scheglov, 2017-08-01 20:58:11]

LGTM

Would be nice to add a test.

https://codereview.chromium.org/2989223002/diff/1/pkg/front_end/lib/increment...
File pkg/front_end/lib/incremental_kernel_generator.dart (right):

https://codereview.chromium.org/2989223002/diff/1/pkg/front_end/lib/increment...
pkg/front_end/lib/incremental_kernel_generator.dart:102: var processedOptions =
new ProcessedOptions(options, false, [entryPoint]);
If seems that "false" is already the default values of the corresponding
parameter.
Maybe all these additional parameters should be made named.

[Siggi Cherem (dart-lang), 2017-08-01 21:07:30]

Thanks. Test added, PTAL

https://codereview.chromium.org/2989223002/diff/1/pkg/front_end/lib/increment...
File pkg/front_end/lib/incremental_kernel_generator.dart (right):

https://codereview.chromium.org/2989223002/diff/1/pkg/front_end/lib/increment...
pkg/front_end/lib/incremental_kernel_generator.dart:102: var processedOptions =
new ProcessedOptions(options, false, [entryPoint]);
On 2017/08/01 20:58:11, scheglov wrote:
> If seems that "false" is already the default values of the corresponding
> parameter.
> Maybe all these additional parameters should be made named.

Yes, I agree. Will follow up separately

[scheglov, 2017-08-01 21:23:53]

lgtm

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
File pkg/front_end/test/incremental_kernel_generator_test.dart (right):

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
pkg/front_end/test/incremental_kernel_generator_test.dart:238: // from the entry
point file.
Please don't put non-documentation comments outside of methods, they might be
disassociated from methods during members sorting.

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
pkg/front_end/test/incremental_kernel_generator_test.dart:243: main() {
This is not quite representative test.

I think it would fail, but it would be better if this file imported a library
using package: URI and referenced an element declared in this library.

[Siggi Cherem (dart-lang), 2017-08-01 21:37:34]

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
File pkg/front_end/test/incremental_kernel_generator_test.dart (right):

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
pkg/front_end/test/incremental_kernel_generator_test.dart:238: // from the entry
point file.
On 2017/08/01 21:23:52, scheglov wrote:
> Please don't put non-documentation comments outside of methods, they might be
> disassociated from methods during members sorting.

Done. (though, that sounds like a bug for the editor?)

https://codereview.chromium.org/2989223002/diff/20001/pkg/front_end/test/incr...
pkg/front_end/test/incremental_kernel_generator_test.dart:243: main() {
On 2017/08/01 21:23:52, scheglov wrote:
> This is not quite representative test.
> 
> I think it would fail, but it would be better if this file imported a library
> using package: URI and referenced an element declared in this library.

Done. Good point. It was before failing as early as we allocated the IKG, which
is why I started with the previous test.

[scheglov, 2017-08-01 21:40:08]

Thanks.
LGTM

[Siggi Cherem (dart-lang), 2017-08-01 22:00:45]

Description was changed from

==========
Pass additional options in incremental setup

With this, we can infer the .packages file on disk.

R=scheglov@google.com
==========

to

==========
Pass additional options in incremental setup

With this, we can infer the .packages file on disk.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d66294cfe241c4fc250d23f6481cf2df69ff3e7a
==========

[Siggi Cherem (dart-lang), 2017-08-01 22:00:46]

Committed patchset #3 (id:40001) manually as
d66294cfe241c4fc250d23f6481cf2df69ff3e7a (presubmit successful).