Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1796)

Unified Diff: base/pickle.h

Issue 298913006: Pickle: don't mark these methods inline when they're not (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/pickle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/pickle.h
diff --git a/base/pickle.h b/base/pickle.h
index dd34f54176c0493154bde29bed3e93a9334ce554..57fece84d490fbc09edb39bcab5ed9d34bfa166e 100644
--- a/base/pickle.h
+++ b/base/pickle.h
@@ -61,11 +61,11 @@ class BASE_EXPORT PickleIterator {
// Read Type from Pickle.
template <typename Type>
- inline bool ReadBuiltinType(Type* result);
+ bool ReadBuiltinType(Type* result);
// Get read pointer for Type and advance read pointer.
template<typename Type>
- inline const char* GetReadPointerAndAdvance();
+ const char* GetReadPointerAndAdvance();
// Get read pointer for |num_bytes| and advance read pointer. This method
// checks num_bytes for negativity and wrapping.
@@ -73,8 +73,7 @@ class BASE_EXPORT PickleIterator {
// Get read pointer for (num_elements * size_element) bytes and advance read
// pointer. This method checks for int overflow, negativity and wrapping.
- inline const char* GetReadPointerAndAdvance(int num_elements,
- size_t size_element);
+ const char* GetReadPointerAndAdvance(int num_elements, size_t size_element);
// Pointers to the Pickle data.
const char* read_ptr_;
@@ -337,7 +336,7 @@ class BASE_EXPORT Pickle {
WriteBytesStatic<sizeof(data)>(&data);
return true;
}
- inline void WriteBytesCommon(const void* data, size_t length);
+ void WriteBytesCommon(const void* data, size_t length);
FRIEND_TEST_ALL_PREFIXES(PickleTest, Resize);
FRIEND_TEST_ALL_PREFIXES(PickleTest, FindNext);
« no previous file with comments | « no previous file | base/pickle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698