Source/devtools/front_end/components/DockController.js - Issue 298913004: [DevTools] Add Toolbox page to undocked DevTools frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/DockController.js

Issue 298913004: [DevTools] Add Toolbox page to undocked DevTools frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/ResponsiveDesignView.js ('K') | « Source/devtools/front_end/common/Settings.js ('k') | Source/devtools/front_end/main/AdvancedApp.js » ('j') | Source/devtools/front_end/main/AdvancedApp.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/DockController.js

diff --git a/Source/devtools/front_end/components/DockController.js b/Source/devtools/front_end/components/DockController.js

index 89903d2c940d4c23842bf939e9faec3165701734..22bc56c41a62061853fdf983a64e73cf0c76478c 100644

--- a/Source/devtools/front_end/components/DockController.js

+++ b/Source/devtools/front_end/components/DockController.js

@@ -123,15 +123,19 @@ WebInspector.DockController.prototype = {

return;

this.dispatchEventToListeners(WebInspector.DockController.Events.BeforeDockSideChanged, dockSide);

- InspectorFrontendHost.setIsDocked(dockSide !== WebInspector.DockController.State.Undocked, this._setIsDockedResponse.bind(this));

+ var oldDockSide = this._dockSide;

+ InspectorFrontendHost.setIsDocked(dockSide !== WebInspector.DockController.State.Undocked, this._setIsDockedResponse.bind(this, oldDockSide));

this._dockSide = dockSide;

this._updateUI();

- this.dispatchEventToListeners(WebInspector.DockController.Events.DockSideChanged, this._dockSide);

+ this.dispatchEventToListeners(WebInspector.DockController.Events.DockSideChanged, oldDockSide);

- _setIsDockedResponse: function()

+ /**

+ * @param {string} oldDockSide

+ */

+ _setIsDockedResponse: function(oldDockSide)

{

- this.dispatchEventToListeners(WebInspector.DockController.Events.AfterDockSideChanged, this._dockSide);

+ this.dispatchEventToListeners(WebInspector.DockController.Events.AfterDockSideChanged, oldDockSide);

_updateUI: function()