Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: Source/devtools/front_end/components/InspectedPagePlaceholder.js

Issue 298913004: [DevTools] Add Toolbox page to undocked DevTools frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/InspectedPagePlaceholder.js
diff --git a/Source/devtools/front_end/components/InspectedPagePlaceholder.js b/Source/devtools/front_end/components/InspectedPagePlaceholder.js
index f268a7f6f96238e22a8249ab49d53e5a06a5c765..fd71140034cb04cf41d421185fbbed2e3917b54f 100644
--- a/Source/devtools/front_end/components/InspectedPagePlaceholder.js
+++ b/Source/devtools/front_end/components/InspectedPagePlaceholder.js
@@ -10,15 +10,17 @@ WebInspector.InspectedPagePlaceholder = function()
{
WebInspector.View.call(this);
this.element.classList.add("white-background");
- WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.ZoomChanged, this._onZoomChanged, this);
+ WebInspector.zoomManager.addEventListener(WebInspector.ZoomManager.Events.ZoomChanged, this._scheduleUpdate, this);
this._margins = { top: 0, right: 0, bottom: 0, left: 0 };
this.restoreMinimumSizeAndMargins();
- WebInspector.dockController.addEventListener(WebInspector.DockController.Events.BeforeDockSideChanged, this._beforeDockSideChange, this);
- WebInspector.dockController.addEventListener(WebInspector.DockController.Events.AfterDockSideChanged, this._afterDockSideChange, this);
};
WebInspector.InspectedPagePlaceholder.MarginValue = 3;
+WebInspector.InspectedPagePlaceholder.Events = {
+ Update: "Update"
+};
+
WebInspector.InspectedPagePlaceholder.prototype = {
_findMargins: function()
{
@@ -47,11 +49,6 @@ WebInspector.InspectedPagePlaceholder.prototype = {
}
},
- _onZoomChanged: function()
- {
- this._scheduleUpdate();
- },
-
onResize: function()
{
this._findMargins();
@@ -60,15 +57,9 @@ WebInspector.InspectedPagePlaceholder.prototype = {
_scheduleUpdate: function()
{
- if (this._noUpdates)
- return;
-
- var dockSide = WebInspector.dockController.dockSide();
- if (dockSide !== WebInspector.DockController.State.Undocked) {
- if (this._updateId)
- window.cancelAnimationFrame(this._updateId);
- this._updateId = window.requestAnimationFrame(this._update.bind(this));
- }
+ if (this._updateId)
+ window.cancelAnimationFrame(this._updateId);
+ this._updateId = window.requestAnimationFrame(this.update.bind(this));
},
/**
@@ -120,26 +111,12 @@ WebInspector.InspectedPagePlaceholder.prototype = {
return { x: left, y: top, width: right - left, height: bottom - top };
},
- _update: function()
+ update: function()
{
delete this._updateId;
- if (this._noUpdates)
- return;
-
var rect = this._dipPageRect();
var bounds = { x: Math.round(rect.x), y: Math.round(rect.y), height: Math.round(rect.height), width: Math.round(rect.width) };
- InspectorFrontendHost.setInspectedPageBounds(bounds);
- },
-
- _beforeDockSideChange: function()
- {
- this._noUpdates = true;
- },
-
- _afterDockSideChange: function()
- {
- this._noUpdates = false;
- this._scheduleUpdate();
+ this.dispatchEventToListeners(WebInspector.InspectedPagePlaceholder.Events.Update, bounds);
},
__proto__: WebInspector.View.prototype

Powered by Google App Engine
This is Rietveld 408576698