Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: Source/devtools/front_end/components/DockController.js

Issue 298913004: [DevTools] Add Toolbox page to undocked DevTools frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed DockSide events Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/common/Settings.js ('k') | Source/devtools/front_end/main/AdvancedApp.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/DockController.js
diff --git a/Source/devtools/front_end/components/DockController.js b/Source/devtools/front_end/components/DockController.js
index 5c940a0221284f8ed18f14c6c4de9561e9ffeccb..24179082f47af9992f7501a75442abf3766b4973 100644
--- a/Source/devtools/front_end/components/DockController.js
+++ b/Source/devtools/front_end/components/DockController.js
@@ -111,16 +111,20 @@ WebInspector.DockController.prototype = {
if (this._dockSide === dockSide)
return;
- this.dispatchEventToListeners(WebInspector.DockController.Events.BeforeDockSideChanged, dockSide);
- InspectorFrontendHost.setIsDocked(dockSide !== WebInspector.DockController.State.Undocked, this._setIsDockedResponse.bind(this));
+ var eventData = { from: this._dockSide, to: dockSide };
+ this.dispatchEventToListeners(WebInspector.DockController.Events.BeforeDockSideChanged, eventData);
+ InspectorFrontendHost.setIsDocked(dockSide !== WebInspector.DockController.State.Undocked, this._setIsDockedResponse.bind(this, eventData));
this._dockSide = dockSide;
this._updateUI();
- this.dispatchEventToListeners(WebInspector.DockController.Events.DockSideChanged, this._dockSide);
+ this.dispatchEventToListeners(WebInspector.DockController.Events.DockSideChanged, eventData);
},
- _setIsDockedResponse: function()
+ /**
+ * @param {{from: string, to: string}} eventData
+ */
+ _setIsDockedResponse: function(eventData)
{
- this.dispatchEventToListeners(WebInspector.DockController.Events.AfterDockSideChanged, this._dockSide);
+ this.dispatchEventToListeners(WebInspector.DockController.Events.AfterDockSideChanged, eventData);
},
_updateUI: function()
« no previous file with comments | « Source/devtools/front_end/common/Settings.js ('k') | Source/devtools/front_end/main/AdvancedApp.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698