chrome/browser/guest_view/guest_view_base.cc - Issue 298913003: Do not allow GuestViewManager to (re)use an instance ID that was already removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 298913003: Do not allow GuestViewManager to (re)use an instance ID that was already removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guest_view/guest_view_base.cc

diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc

index 574730522f5ef44db091f2eee10946697244598d..9f3eba71569e1a8a911b595166fb61513be11f95 100644

--- a/chrome/browser/guest_view/guest_view_base.cc

+++ b/chrome/browser/guest_view/guest_view_base.cc

@@ -52,8 +52,8 @@ GuestViewBase::GuestViewBase(int guest_instance_id,

weak_ptr_factory_(this) {

webcontents_guestview_map.Get().insert(

std::make_pair(guest_web_contents, this));

- GuestViewManager::FromBrowserContext(browser_context_)->

- AddGuest(guest_instance_id_, guest_web_contents);

+ DCHECK(GuestViewManager::FromBrowserContext(browser_context_)

+ ->AddGuest(guest_instance_id_, guest_web_contents));

}

// static

« no previous file with comments | « no previous file | chrome/browser/guest_view/guest_view_manager.h » ('j') | chrome/browser/guest_view/guest_view_manager.cc » ('J')