Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 298913003: Do not allow GuestViewManager to (re)use an instance ID that was already removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/guest_view/guest_view_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/guest_view_base.cc
diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc
index 574730522f5ef44db091f2eee10946697244598d..9f3eba71569e1a8a911b595166fb61513be11f95 100644
--- a/chrome/browser/guest_view/guest_view_base.cc
+++ b/chrome/browser/guest_view/guest_view_base.cc
@@ -52,8 +52,8 @@ GuestViewBase::GuestViewBase(int guest_instance_id,
weak_ptr_factory_(this) {
webcontents_guestview_map.Get().insert(
std::make_pair(guest_web_contents, this));
- GuestViewManager::FromBrowserContext(browser_context_)->
- AddGuest(guest_instance_id_, guest_web_contents);
+ DCHECK(GuestViewManager::FromBrowserContext(browser_context_)
lazyboy 2014/05/22 15:59:31 Q: Do we need a CHECK here too?
Fady Samuel 2014/05/22 17:41:53 If we have a CHECK inside AddGuest then why do we
lazyboy 2014/05/22 18:34:45 The return value was for test, I've moved the logi
+ ->AddGuest(guest_instance_id_, guest_web_contents));
}
// static
« no previous file with comments | « no previous file | chrome/browser/guest_view/guest_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698