Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly

Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly (https://codereview.chromium.org/268833003/)

Reason for revert:
May have caused a clusterfuzz regression: https://code.google.com/p/chromium/issues/detail?id=375954

Original issue's description:
> Refactor avoidsFloats() to reflect CSS2.1 spec more clearly
> 
> Introduce the 'createsBlockFormatting' concept to RenderBlock::avoidsFloats()
> and remove a couple of now-redundant virtualizations of the function.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173549

[rhogan, 2014-05-21 21:50:46]

Created Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly

[rhogan, 2014-05-21 21:53:06]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2014-05-21 21:53:12]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-21 22:04:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robhogan@gmail.com/298913002/1

[commit-bot: I haz the power, 2014-05-21 22:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 22:04:16]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[robhogan (do not use), 2014-05-21 22:05:37]

The CQ bit was checked by robhogan@chromium.org

[commit-bot: I haz the power, 2014-05-21 22:07:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robhogan@gmail.com/298913002/1

[commit-bot: I haz the power, 2014-05-21 22:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 22:07:13]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2014-05-21 22:09:50]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2014-05-21 22:10:10]

lgtm.

[commit-bot: I haz the power, 2014-05-21 22:11:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robhogan@gmail.com/298913002/1

[commit-bot: I haz the power, 2014-05-22 07:46:31]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 07:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 07:47:49]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[rhogan, 2014-05-22 10:07:07]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2014-05-22 10:07:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robhogan@gmail.com/298913002/1

[commit-bot: I haz the power, 2014-05-22 10:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 10:08:03]

Failed to apply patch for Source/core/rendering/RenderBlock.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/RenderBlock.h
  Hunk #1 succeeded at 325 (offset -2 lines).
  Hunk #2 FAILED at 388.
  Hunk #3 succeeded at 468 (offset -1 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/rendering/RenderBlock.h.rej

Patch:       Source/core/rendering/RenderBlock.h
Index: Source/core/rendering/RenderBlock.h
diff --git a/Source/core/rendering/RenderBlock.h
b/Source/core/rendering/RenderBlock.h
index
94e6b7f797282e21ea2585fd61fa3d6dcf886811..74af6b2a6384b5eb30b59e35c550c92b8ded3761
100644
--- a/Source/core/rendering/RenderBlock.h
+++ b/Source/core/rendering/RenderBlock.h
@@ -327,7 +327,6 @@
 
     void setDesiredColumnCountAndWidth(int, LayoutUnit);
 
-    bool avoidsOrIgnoresFloats() { return isFloatingOrOutOfFlowPositioned() ||
avoidsFloats(); }
 public:
     virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false);
 protected:
@@ -389,6 +388,8 @@
 
     bool hasCaret() const { return hasCaret(CursorCaret) ||
hasCaret(DragCaret); }
     bool hasCaret(CaretType) const;
+
+    virtual bool avoidsFloats() const OVERRIDE;
 
     bool hitTestColumns(const HitTestRequest&, HitTestResult&, const
HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset,
HitTestAction);
     bool hitTestContents(const HitTestRequest&, HitTestResult&, const
HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset,
HitTestAction);
@@ -470,6 +471,8 @@
     enum PageBoundaryRule { ExcludePageBoundary, IncludePageBoundary };
     LayoutUnit nextPageLogicalTop(LayoutUnit logicalOffset, PageBoundaryRule =
ExcludePageBoundary) const;
 
+    bool createsBlockFormattingContext() const;
+
 public:
     LayoutUnit pageLogicalTopForOffset(LayoutUnit offset) const;
     LayoutUnit pageLogicalHeightForOffset(LayoutUnit offset) const;