[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, or later …

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 51 matching lines @@
 bool Profiler::initialized_ = false;
 SampleBuffer* Profiler::sample_buffer_ = NULL;
 AllocationSampleBuffer* Profiler::allocation_sample_buffer_ = NULL;
 ProfilerCounters Profiler::counters_;
 
 void Profiler::InitOnce() {
   // Place some sane restrictions on user controlled flags.
   SetSamplePeriod(FLAG_profile_period);
   SetSampleDepth(FLAG_max_profile_depth);
   Sample::InitOnce();
+#if !defined(TARGET_ARCH_DBC)

[zra, 2017/07/31 15:03:11]

I thought the profiler was kind of working somewhat for DBC. Does this CL turn
it off?

[rmacnak, 2017/07/31 21:12:12]

Removed; this was a bad merge. I was working from a CL I started a long time ago
before the profiler support was added for DBC. The profiler indeed works for
DBC, though it only has function-level resolution instead of instruction-level
resolution since we avoid flushing the instruction pointer to memory the
profiler can read.

   if (!FLAG_profiler) {
     return;
   }
   ASSERT(!initialized_);
   sample_buffer_ = new SampleBuffer();
   Profiler::InitAllocationSampleBuffer();
   // Zero counters.
   memset(&counters_, 0, sizeof(counters_));
   NativeSymbolResolver::InitOnce();
+  ThreadInterrupter::InitOnce();
   ThreadInterrupter::SetInterruptPeriod(FLAG_profile_period);
   ThreadInterrupter::Startup();
   initialized_ = true;
+#endif  // !DBC
 }
 
 void Profiler::InitAllocationSampleBuffer() {
   if (FLAG_profiler_native_memory &&
       (Profiler::allocation_sample_buffer_ == NULL)) {
     Profiler::allocation_sample_buffer_ = new AllocationSampleBuffer();
   }
 }
 
 void Profiler::Shutdown() {
+#if !defined(TARGET_ARCH_DBC)
   if (!FLAG_profiler) {
     return;
   }
   ASSERT(initialized_);
   ThreadInterrupter::Shutdown();
   NativeSymbolResolver::ShutdownOnce();
+// Note we do not free the sample buffer because there may be SIGPROFs

[zra, 2017/07/31 15:03:11]

Can you set a "shutting down" bit somewhere that the signal handler will look
at? If it's set, then it can e.g. return immediately without touching the sample
buffer.

[rmacnak, 2017/07/31 21:12:12]

The signal handler could be between that check and writing the sample when we
want to free the sample buffer. We'd need a critical section around both the
check and the use of the sample buffer (which is nearly all of the signal
handler). thread_interrupt.cc has a lengthy comment explaining that we can't
take locks.

[zra, 2017/07/31 21:59:28]

Maybe some thing like:

Signal handler:
AtomicInc(&some_counter);
if (shutting_down) {
  AtomicDec(&some_counter);
  return;
}
...
AtomicDec(&some_counter);


Thread Interrupter thread:
RemoveSignalHandler();
shutting_down = true;
while (some_counter > 0) {
  usleep(1000);
}
free(sample_buffer);

[rmacnak, 2017/08/01 19:58:58]

Added TODO(30309)

+// in flight.
+#endif  // !DBC
 }
 
 void Profiler::SetSampleDepth(intptr_t depth) {
   const int kMinimumDepth = 2;
   const int kMaximumDepth = 255;
   if (depth < kMinimumDepth) {
     FLAG_max_profile_depth = kMinimumDepth;
   } else if (depth > kMaximumDepth) {
     FLAG_max_profile_depth = kMaximumDepth;
   } else {
@@ skipping 1571 matching lines @@
 }
 
 ProcessedSampleBuffer::ProcessedSampleBuffer()
     : code_lookup_table_(new CodeLookupTable(Thread::Current())) {
   ASSERT(code_lookup_table_ != NULL);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart