Add memory-dashboard page to Observatory

Add memory-dashboard page to Observatory

A new hidden page in observatory that will be used from external IDEs.
This initial version focuses on the evolution of the memory usage in time
and per isolate allocation profile.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://codereview.chromium.org/2990913002/

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/c6a71098b6729cc5ea837f3d5ecf1bba7ce36332

[cbernaschina, 2017-07-31 16:38:06]

Description was changed from

==========
Add memory-dashboard page to Observatory

A new hidden page in observatory that will be used from external IDEs.
This initial version focuses on the evolution of the memory usage in time
and per isolate allocation profile.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://codereview.chromium.org/2990913002/
==========

to

==========
Add memory-dashboard page to Observatory

A new hidden page in observatory that will be used from external IDEs.
This initial version focuses on the evolution of the memory usage in time
and per isolate allocation profile.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://codereview.chromium.org/2990913002/
==========

[cbernaschina, 2017-07-31 16:38:06]

cbernaschina@google.com changed reviewers:
+ rmacnak@google.com, zra@google.com

[rmacnak, 2017-07-31 16:50:46]

I get "No isolate selected" trying to visit urls like
http://127.0.0.1:8181/#/memory-dashboard?isolateId=isolates%2F330870970. I'm
sure I have a valid isolate id because the url is derived from visiting the
allocation table page.

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/.packages
File runtime/observatory/.packages (right):

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/.packag...
runtime/observatory/.packages:14:
func:file:///usr/local/google/home/cbernaschina/.pub-cache/hosted/pub.dartlang.org/func-1.0.0/lib/
Shouldn't have any paths specific to your machine.

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/pubspec...
File runtime/observatory/pubspec.lock (right):

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/pubspec...
runtime/observatory/pubspec.lock:80: source: hosted
These should all be paths pointing into observatory_pub_packages, no?

[cbernaschina, 2017-07-31 20:23:53]

cbernaschina@google.com changed reviewers:
+ asiva@google.com

[cbernaschina, 2017-07-31 20:23:54]

Landed https://codereview.chromium.org/2990913002/ which was necessary to
actually try the code in this CL.

Nitpick: The dashboard is isolate independent so the url is
http://127.0.0.1:8181/#/memory-dashboard

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/.packages
File runtime/observatory/.packages (right):

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/.packag...
runtime/observatory/.packages:14:
func:file:///usr/local/google/home/cbernaschina/.pub-cache/hosted/pub.dartlang.org/func-1.0.0/lib/
On 2017/07/31 16:50:46, rmacnak wrote:
> Shouldn't have any paths specific to your machine.

Landed https://codereview.chromium.org/2990913002/ and runned pub get again

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/pubspec...
File runtime/observatory/pubspec.lock (right):

https://codereview.chromium.org/2989083002/diff/1/runtime/observatory/pubspec...
runtime/observatory/pubspec.lock:80: source: hosted
On 2017/07/31 16:50:46, rmacnak wrote:
> These should all be paths pointing into observatory_pub_packages, no?

Landed https://codereview.chromium.org/2990913002/ and runned pub get again

[cbernaschina, 2017-08-02 23:23:58]

Upgrade to the latest format of the virtual-collection 

Related https://codereview.chromium.org/2991203002/

[siva, 2017-08-03 18:14:51]

lgtm with some comments.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/app/page.dart:708: // Preload all isolate to avoid
sorting problems
isolates

and period at the end.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/app/page.dart:716:
Logger.root.severe('MemoryDashboard visit error: $e');
Where does these messages show up?

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/dashboard.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/dashboard.dart:4: 
For all these new files it might be nice to add a small comment blob on the top
describing what functionality is implemented here.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/dashboard.dart:34: M.VM get vm =>
_vm;
How does this work? _vm is a M.VMRef type and the getter's return type is M.VM

(Have you run this code through the analyzer with --strong turned on.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/graph.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/graph.dart:4: 
Ditto comment about adding a comment blob here.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/graph.dart:19: class DataPoint {}
What is this empty class for?

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/profile.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/profile.dart:1: // Copyright (c)
2014, the Dart project authors.  Please see the AUTHORS file
2017

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/utils.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/utils.dart:159: : duration.inMicroseconds;
Would it be the same as
var value = duration.inMicroseconds.abs();  ?

[cbernaschina, 2017-08-03 22:32:53]

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/app/page.dart:708: // Preload all isolate to avoid
sorting problems
On 2017/08/03 18:14:51, siva wrote:
> isolates
> 
> and period at the end.

Done.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/app/page.dart:716:
Logger.root.severe('MemoryDashboard visit error: $e');
On 2017/08/03 18:14:51, siva wrote:
> Where does these messages show up?

In the console of the browser

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/dashboard.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/dashboard.dart:4: 
On 2017/08/03 18:14:51, siva wrote:
> For all these new files it might be nice to add a small comment blob on the
top
> describing what functionality is implemented here.

Done.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/dashboard.dart:34: M.VM get vm =>
_vm;
On 2017/08/03 18:14:51, siva wrote:
> How does this work? _vm is a M.VMRef type and the getter's return type is M.VM
> 
> (Have you run this code through the analyzer with --strong turned on.

Done

(see mail about the strong mode analyzer)

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/graph.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/graph.dart:4: 
On 2017/08/03 18:14:51, siva wrote:
> Ditto comment about adding a comment blob here.

Done.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/graph.dart:19: class DataPoint {}
On 2017/08/03 18:14:51, siva wrote:
> What is this empty class for?

Done.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/memory/profile.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/memory/profile.dart:1: // Copyright (c)
2014, the Dart project authors.  Please see the AUTHORS file
On 2017/08/03 18:14:51, siva wrote:
> 2017

Done.

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/utils.dart (right):

https://codereview.chromium.org/2989083002/diff/100001/runtime/observatory/li...
runtime/observatory/lib/utils.dart:159: : duration.inMicroseconds;
On 2017/08/03 18:14:51, siva wrote:
> Would it be the same as
> var value = duration.inMicroseconds.abs();  ?

Done.

[cbernaschina, 2017-08-03 22:52:31]

Description was changed from

==========
Add memory-dashboard page to Observatory

A new hidden page in observatory that will be used from external IDEs.
This initial version focuses on the evolution of the memory usage in time
and per isolate allocation profile.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://codereview.chromium.org/2990913002/
==========

to

==========
Add memory-dashboard page to Observatory

A new hidden page in observatory that will be used from external IDEs.
This initial version focuses on the evolution of the memory usage in time
and per isolate allocation profile.

Related https://github.com/dart-lang/sdk/issues/30023
Related https://codereview.chromium.org/2990913002/

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c6a71098b6729cc5ea837f3d5ecf1bba7ce36332
==========

[cbernaschina, 2017-08-03 22:52:32]

Committed patchset #10 (id:180001) manually as
c6a71098b6729cc5ea837f3d5ecf1bba7ce36332 (presubmit successful).