Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: pkg/front_end/messages.yaml

Issue 2989073002: [fasta] Issue error for large integer literals (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/messages.yaml
diff --git a/pkg/front_end/messages.yaml b/pkg/front_end/messages.yaml
index b0a3d1c618dcf5a985b8518df87e9c5d50f2c21c..bb25bac74c3333135e8da57727b7b6930ba9d61f 100644
--- a/pkg/front_end/messages.yaml
+++ b/pkg/front_end/messages.yaml
@@ -896,3 +896,6 @@ PackageNotFound:
InvalidPackageUri:
template: "Invalid package Uri '#uri':\n #string."
+
+IntegerLiteralIsOutOfRange:
+ template: "Integer literal #lexeme is out of range"
ahe 2017/08/01 11:34:13 A great message conveys the following three things
ahe 2017/08/01 11:34:13 Add single quotes around #lexeme. See also pkg/fro
ahe 2017/08/01 11:34:13 Add period at end of sentence.
alexmarkov 2017/08/01 20:14:44 Done.
alexmarkov 2017/08/01 20:14:44 Can you suggest an error message for invalid integ
alexmarkov 2017/08/01 20:14:44 Done. Note that pkg/front_end/lib/src/fasta/diagno
ahe 2017/08/03 17:10:16 template: "The integer literal #lexeme can't be re
ahe 2017/08/03 17:10:16 Thank you, let's follow what the document says, al
alexmarkov 2017/08/14 17:56:36 Done.
alexmarkov 2017/08/14 17:56:36 Done.

Powered by Google App Engine
This is Rietveld 408576698