pkg/front_end/messages.yaml - Issue 2989073002: [fasta] Issue error for large integer literals

Side by Side Diff: pkg/front_end/messages.yaml

Issue 2989073002: [fasta] Issue error for large integer literals (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('K') | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 # Each entry in this map corresponds to a diagnostic message. Ideally, each	5 # Each entry in this map corresponds to a diagnostic message. Ideally, each

6 # entry contains three parts:	6 # entry contains three parts:

7 #	7 #

8 # 1. A message template (template).	8 # 1. A message template (template).

9 #	9 #

10 # 2. A suggestion for how to correct the problem (tip).	10 # 2. A suggestion for how to correct the problem (tip).

(...skipping 878 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
889	889

890 CantInferPackagesFromPackageUri:	890 CantInferPackagesFromPackageUri:

891 template: "Can't infer a .packages file from an input 'package:*' URI."	891 template: "Can't infer a .packages file from an input 'package:*' URI."

892 tip: "Try specifying the file explicitly with the --packages option."	892 tip: "Try specifying the file explicitly with the --packages option."

893	893

894 PackageNotFound:	894 PackageNotFound:

895 template: "Could not resolve the package '#name' in '#uri'."	895 template: "Could not resolve the package '#name' in '#uri'."

896	896

897 InvalidPackageUri:	897 InvalidPackageUri:

898 template: "Invalid package Uri '#uri':\n #string."	898 template: "Invalid package Uri '#uri':\n #string."

	899

	900 IntegerLiteralIsOutOfRange:

	901 template: "Integer literal #lexeme is out of range"
	ahe 2017/08/01 11:34:13 A great message conveys the following three things A great message conveys the following three things: 1. What is wrong? 2. Why is it wrong? 3. How do I fix it? ahe 2017/08/01 11:34:13 Add single quotes around #lexeme. See also pkg/fro Add single quotes around #lexeme. See also pkg/front_end/lib/src/fasta/diagnostics.md. ahe 2017/08/01 11:34:13 Add period at end of sentence. Add period at end of sentence. alexmarkov 2017/08/01 20:14:44 Done. Show quoted text On 2017/08/01 11:34:13, ahe wrote: > Add period at end of sentence. Done. alexmarkov 2017/08/01 20:14:44 Can you suggest an error message for invalid integ Show quoted text On 2017/08/01 11:34:13, ahe wrote: > A great message conveys the following three things: > > 1. What is wrong? > 2. Why is it wrong? > 3. How do I fix it? Can you suggest an error message for invalid integer literals which would satisfy these requirements? alexmarkov 2017/08/01 20:14:44 Done. Note that pkg/front_end/lib/src/fasta/diagno Show quoted text On 2017/08/01 11:34:13, ahe wrote: > Add single quotes around #lexeme. See also > pkg/front_end/lib/src/fasta/diagnostics.md. Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not quote `null` and numeric literals." ahe 2017/08/03 17:10:16 template: "The integer literal #lexeme can't be re Show quoted text On 2017/08/01 20:14:44, alexmarkov wrote: > On 2017/08/01 11:34:13, ahe wrote: > > A great message conveys the following three things: > > > > 1. What is wrong? > > 2. Why is it wrong? > > 3. How do I fix it? > > Can you suggest an error message for invalid integer literals which would > satisfy these requirements? template: "The integer literal #lexeme can't be represented in 64 bits." tip: "Try using <what> if you need an integer larger than 9,223,372,036,854,775,807 or less than -9,223,372,036,854,775,808." ahe 2017/08/03 17:10:16 Thank you, let's follow what the document says, al Show quoted text On 2017/08/01 20:14:44, alexmarkov wrote: > Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not quote > `null` and numeric literals." Thank you, let's follow what the document says, although it's author can't remember what it says :-) alexmarkov 2017/08/14 17:56:36 Done. Show quoted text On 2017/08/01 20:14:44, alexmarkov wrote: > On 2017/08/01 11:34:13, ahe wrote: > > A great message conveys the following three things: > > > > 1. What is wrong? > > 2. Why is it wrong? > > 3. How do I fix it? > > Can you suggest an error message for invalid integer literals which would > satisfy these requirements? Done. alexmarkov 2017/08/14 17:56:36 Done. Show quoted text On 2017/08/03 17:10:16, ahe wrote: > On 2017/08/01 20:14:44, alexmarkov wrote: > > Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not quote > > `null` and numeric literals." > > Thank you, let's follow what the document says, although it's author can't > remember what it says :-) Done.
OLD	NEW