Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2988973002: Better support for re-running in the middle of a migration. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Better support for re-running in the middle of a migration. - Track files that only exist in the "_2" directories. That way we can show what work still remains to be done even if the unmigrated files are gone. - Friendlier matching of command line arguments. Pass in any substring of the test path and if only one test matches, it will be used. - Make --dry-run not crash. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/1419935fa62f65781518608fcddccbd14bab0856

Patch Set 1 #

Patch Set 2 : Better support for re-running in the middle of a migration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -193 lines) Patch
M tools/migration/bin/migrate_batch.dart View 1 7 chunks +57 lines, -193 lines 0 comments Download
A tools/migration/lib/src/fork.dart View 1 1 chunk +117 lines, -0 lines 0 comments Download
A tools/migration/lib/src/io.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bob Nystrom
The first patchset just moves stuff into separate files. Then the second one contains the ...
3 years, 4 months ago (2017-07-27 18:03:18 UTC) #3
bkonyi
LGTM
3 years, 4 months ago (2017-07-27 19:04:28 UTC) #4
Bob Nystrom
3 years, 4 months ago (2017-07-27 19:07:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1419935fa62f65781518608fcddccbd14bab0856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698