Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2988953002: Remove "Windows toolchain" step from DEPS. May only be used by gyp. (Closed)

Created:
3 years, 4 months ago by Bill Hesse
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove "Windows toolchain" step from DEPS. May only be used by gyp. BUG=570091, 748486 R=phajdan.jr@chromium.org Committed: https://github.com/dart-lang/sdk/commit/5a8520ba91045b17ee6523aa7d46e3e7f23fd5d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bill Hesse
TBR=kustermann It looks like this step may only be used by the gyp builds for ...
3 years, 4 months ago (2017-07-27 11:19:31 UTC) #2
Paweł Hajdan Jr.
LGTM
3 years, 4 months ago (2017-07-27 11:20:03 UTC) #4
Bill Hesse
3 years, 4 months ago (2017-07-27 11:21:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a8520ba91045b17ee6523aa7d46e3e7f23fd5d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698