Add WebSocket unittests.

Source/modules/websockets/WebSocket.h

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 #include "wtf/Forward.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/text/AtomicStringHash.h"
 
 namespace WebCore {
 
 class Blob;
 class ExceptionState;
 
-class WebSocket FINAL : public RefCountedWillBeRefCountedGarbageCollected<WebSocket>, public ScriptWrappable, public EventTargetWithInlineData, public ActiveDOMObject, public WebSocketChannelClient {
+class WebSocket : public RefCountedWillBeRefCountedGarbageCollected<WebSocket>, public ScriptWrappable, public EventTargetWithInlineData, public ActiveDOMObject, public WebSocketChannelClient {
     DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedWillBeRefCountedGarbageCollected<WebSocket>);
 public:
-    static const char* subProtocolSeperator();
+    static const char* subprotocolSeperator();
     // WebSocket instances must be used with a wrapper since this class's
     // lifetime management is designed assuming the V8 holds a ref on it while
     // hasPendingActivity() returns true.
     static PassRefPtrWillBeRawPtr<WebSocket> create(ExecutionContext*, const String& url, ExceptionState&);
     static PassRefPtrWillBeRawPtr<WebSocket> create(ExecutionContext*, const String& url, const String& protocol, ExceptionState&);
     static PassRefPtrWillBeRawPtr<WebSocket> create(ExecutionContext*, const String& url, const Vector<String>& protocols, ExceptionState&);
     virtual ~WebSocket();
 
     enum State {
         CONNECTING = 0,
@@ skipping 48 matching lines @@
 
     // WebSocketChannelClient functions.
     virtual void didConnect() OVERRIDE;
     virtual void didReceiveMessage(const String& message) OVERRIDE;
     virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> >) OVERRIDE;
     virtual void didReceiveMessageError() OVERRIDE;
     virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) OVERRIDE;
     virtual void didStartClosingHandshake() OVERRIDE;
     virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;
 
     void trace(Visitor*);

[haraken, 2014/05/27 04:35:08]

You need to make this a virtual method.

[yhirano, 2014/05/27 05:03:02]

Done.

[haraken, 2014/05/27 05:23:56]

Ian: Would it be possible to detect missing 'virtual's on trace methods by the
plugin?

[zerny-chromium, 2014/05/27 08:26:28]

Actually, is should already have issued an error for this, but due to an error
in the InCheckedNamespace code it does not validate the subclass trace. Which
overrides a non-virtual trace method. I'm uploading a CL to fix this ASAP.
Thanks for raising the question!

 
+    static bool isValidSubprotocolString(const String&);
+
+protected:
+    explicit WebSocket(ExecutionContext*);
+
 private:
     // FIXME: This should inherit WebCore::EventQueue.
     class EventQueue FINAL : public RefCountedWillBeGarbageCollectedFinalized<EventQueue> {
     public:
         static PassRefPtrWillBeRawPtr<EventQueue> create(EventTarget* target)
         {
             return adoptRefWillBeNoop(new EventQueue(target));
         }
         ~EventQueue();
 
@@ skipping 31 matching lines @@
     };
 
     enum WebSocketSendType {
         WebSocketSendTypeString,
         WebSocketSendTypeArrayBuffer,
         WebSocketSendTypeArrayBufferView,
         WebSocketSendTypeBlob,
         WebSocketSendTypeMax,
     };
 
-    explicit WebSocket(ExecutionContext*);
+    // This function is virtual for unittests.
+    // FIXME: Move WebSocketChannel::create here.
+    virtual PassRefPtrWillBeRawPtr<WebSocketChannel> createChannel(ExecutionContext* context, WebSocketChannelClient* client)
+    {
+        return WebSocketChannel::create(context, client);
+    }
 
     // Adds a console message with JSMessageSource and ErrorMessageLevel.
     void logError(const String& message);
 
     // Handle the JavaScript close method call. close() methods on this class
     // are just for determining if the optional code argument is supplied or
     // not.
     void closeInternal(int, const String&, ExceptionState&);
 
     size_t getFramingOverhead(size_t payloadSize);
@@ skipping 25 matching lines @@
     // The subprotocol the server selected.
     String m_subprotocol;
     String m_extensions;
 
     RefPtrWillBeMember<EventQueue> m_eventQueue;
 };
 
 } // namespace WebCore
 
 #endif // WebSocket_h