Issue 298893006: Split modules-dependent Event code in core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298893006: Split modules-dependent Event code in core. (Closed)

Created:
6 years, 7 months ago by c.shu

Modified:
6 years, 7 months ago

Reviewers:
Nils Barth (inactive), eseidel

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Split modules-dependent Event code in core. BUG=376506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174706

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -66 lines)			Patch
D	Source/bindings/core_bindings_generated.gyp	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	Source/bindings/scripts/generate_event_interfaces.py	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/custom/V8EventCustom.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/build/scripts/templates/EventFactory.cpp.tmpl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/Init.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/Init.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/core_generated.gyp	View	2 chunks	+36 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/events/Event.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/events/EventFactory.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/modules/EventTargetModules.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/InitModules.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/InitModules.cpp	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	Source/modules/modules.gyp	View	3 chunks	+76 lines, -1 line	0 comments	Download
M	Source/modules/modules.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

c.shu

Will try to take care the TODO in Document.cpp in a follow-up.

6 years, 7 months ago (2014-05-22 21:36:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/298893006/1

6 years, 7 months ago (2014-05-23 18:24:11 UTC) #3

Message was sent while issue was closed.

Change committed as 174706

Expand Messages | Collapse Messages