Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: ui/wm/core/input_method_event_filter.cc

Issue 298893003: Supports fake key events for setComposition/commitText by on-screen keyboards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ... Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/wm/core/input_method_event_filter.cc
diff --git a/ui/wm/core/input_method_event_filter.cc b/ui/wm/core/input_method_event_filter.cc
index 65bd5b506460b61d7dbe6c43a43f13f15882fe3f..735f7b43a3766d1feffcccd69ce04829b57df3c6 100644
--- a/ui/wm/core/input_method_event_filter.cc
+++ b/ui/wm/core/input_method_event_filter.cc
@@ -88,9 +88,11 @@ bool InputMethodEventFilter::DispatchKeyEventPostIME(
// dispatched event.
ui::KeyEvent aura_event(event);
aura_event.SetTranslated(true);
- ui::EventDispatchDetails details =
- target_dispatcher_->OnEventFromSource(&aura_event);
- CHECK(!details.dispatcher_destroyed);
+ if (target_dispatcher_) {
Yuki 2014/05/28 06:04:19 Do you really need this check? In which cases wil
Shu Chen 2014/05/28 06:59:50 When DispatchKeyEventPostIME() method is called wi
+ ui::EventDispatchDetails details =
+ target_dispatcher_->OnEventFromSource(&aura_event);
+ CHECK(!details.dispatcher_destroyed);
+ }
return aura_event.handled();
}
« ui/base/ime/input_method_chromeos.h ('K') | « ui/base/ime/input_method_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698