Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298883012: Added GetURL, GetOAuthScope, GetExtraRequestHeaders into GCDBaseApiFlow::Delegate. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Added GetURL, GetOAuthScope, GetExtraRequestHeaders into GCDBaseApiFlow::Delegate. TBR=noamsml NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272933

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -142 lines) Patch
M chrome/browser/local_discovery/cloud_device_list.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/local_discovery/cloud_device_list.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_printer_list.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/cloud_print_printer_list.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/gcd_base_api_flow.h View 3 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/local_discovery/gcd_base_api_flow.cc View 6 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow.cc View 4 chunks +12 lines, -36 lines 0 comments Download
M chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc View 1 6 chunks +0 lines, -47 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 7 months ago (2014-05-23 23:45:23 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-23 23:45:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/1
6 years, 7 months ago (2014-05-23 23:46:29 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 04:51:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 05:27:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/145612)
6 years, 7 months ago (2014-05-24 05:27:52 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-24 20:01:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/1
6 years, 7 months ago (2014-05-24 23:19:54 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 01:12:16 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 01:51:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/145661)
6 years, 7 months ago (2014-05-25 01:51:26 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-25 07:30:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/20001
6 years, 7 months ago (2014-05-25 07:31:07 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 09:07:10 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 09:15:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77479)
6 years, 7 months ago (2014-05-25 09:15:43 UTC) #16
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-25 09:40:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/20001
6 years, 7 months ago (2014-05-25 09:40:54 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 09:49:12 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 10:11:30 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77482)
6 years, 7 months ago (2014-05-25 10:11:30 UTC) #21
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-27 07:00:14 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/20001
6 years, 6 months ago (2014-05-27 07:00:41 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 6 months ago (2014-05-27 07:05:09 UTC) #24
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-27 07:17:17 UTC) #25
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-27 07:17:36 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/298883012/20001
6 years, 6 months ago (2014-05-27 07:17:47 UTC) #27
commit-bot: I haz the power
6 years, 6 months ago (2014-05-27 08:26:36 UTC) #28
Message was sent while issue was closed. 
Change committed as 272933

Powered by Google App Engine
This is Rietveld 408576698