net/http/http_stream_factory_impl_job.cc - Issue 298883011: Record errors that trigger a data reduction proxy bypass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 298883011: Record errors that trigger a data reduction proxy bypass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from mdw Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_factory_impl_job.cc

diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc

index 8cd2de0dbdf2a48d729226f74da1c951d6475426..3fad3d1274d36a7dbcc69d85085d52f94ab59dad 100644

--- a/net/http/http_stream_factory_impl_job.cc

+++ b/net/http/http_stream_factory_impl_job.cc

@@ -1348,7 +1348,8 @@ int HttpStreamFactoryImpl::Job::ReconsiderProxyAfterError(int error) {

}

int rv = session_->proxy_service()->ReconsiderProxyAfterError(

- request_info_.url, &proxy_info_, io_callback_, &pac_request_, net_log_);

+ request_info_.url, error, &proxy_info_, io_callback_, &pac_request_,

+ net_log_);

if (rv == OK || rv == ERR_IO_PENDING) {

// If the error was during connection setup, there is no socket to

// disconnect.

« no previous file with comments | « net/http/http_response_headers_unittest.cc ('k') | net/proxy/proxy_service.h » ('j') | net/proxy/proxy_service.cc » ('J')