Record errors that trigger a data reduction proxy bypass

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 994 matching lines @@
     }
 #endif
 
     if (data_reduction_proxy_used || data_reduction_fallback_proxy_used) {
       net::HttpResponseHeaders::DataReductionProxyInfo
       data_reduction_proxy_info;
       proxy_bypass_event
           = response_.headers->GetDataReductionProxyBypassEventType(
               &data_reduction_proxy_info);
       if (proxy_bypass_event < ProxyService::BYPASS_EVENT_TYPE_MAX) {
+        // Bypass all proxies for one second on reception of a 4xx that
+        // originated at the proxy.

[Matt Welsh, 2014/05/23 23:56:30]

We shouldn't be bypassing all 4xx errors. This should only be happening if the
Via header is missing. Many origin sites produce (valid) 4xx errors and the last
thing we want is all of them to turn into bypasses.

[bengr, 2014/05/24 01:22:02]

GetDataReductionBypassEventType decides if we should bypass. This code just sets
up the right bypass if we should.

+        if (proxy_bypass_event == ProxyService::CLIENT_ERROR_BYPASS) {
+          data_reduction_proxy_info.bypass_all = true;
+          data_reduction_proxy_info.bypass_duration =
+              base::TimeDelta::FromSeconds(1);
+        }
+
         ProxyService* proxy_service = session_->proxy_service();
 
         proxy_service->RecordDataReductionProxyBypassInfo(
             data_reduction_proxy_used, proxy_info_.proxy_server(),
             proxy_bypass_event);
 
         ProxyServer proxy_server;
 #if defined(DATA_REDUCTION_FALLBACK_HOST)
         if (data_reduction_proxy_used && data_reduction_proxy_info.bypass_all) {
           // TODO(bengr): Rename as DATA_REDUCTION_FALLBACK_ORIGIN.
@@ skipping 586 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net