chrome/browser/extensions/extension_test_notification_observer.cc - Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_test_notification_observer.cc

Issue 298883006: Rename NOTIFICATION_EXTENSION_INSTALLED to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_test_notification_observer.cc

diff --git a/chrome/browser/extensions/extension_test_notification_observer.cc b/chrome/browser/extensions/extension_test_notification_observer.cc

index 9844642bb55fcf89e215303af0b3d01a79d2625c..c4e3631c7180e27ab76590f208ba81472ed25a25 100644

--- a/chrome/browser/extensions/extension_test_notification_observer.cc

+++ b/chrome/browser/extensions/extension_test_notification_observer.cc

@@ -185,7 +185,7 @@ bool ExtensionTestNotificationObserver::WaitForExtensionViewsToLoad() {

bool ExtensionTestNotificationObserver::WaitForExtensionInstall() {

int before = extension_installs_observed_;

- WaitForNotification(chrome::NOTIFICATION_EXTENSION_INSTALLED);

+ WaitForNotification(chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED);

return extension_installs_observed_ == (before + 1);

}

@@ -272,7 +272,7 @@ void ExtensionTestNotificationObserver::Observe(

++crx_installers_done_observed_;

break;

- case chrome::NOTIFICATION_EXTENSION_INSTALLED:

+ case chrome::NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED:

VLOG(1) << "Got EXTENSION_INSTALLED notification.";

++extension_installs_observed_;

break;