Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: tracing/tracing/value/histogram_unittest.py

Issue 2988823002: DeviceInfo into GenericSets (Closed)
Patch Set: Remove how-to-write-metrics-device image Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/ui/device_info_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_unittest.py
diff --git a/tracing/tracing/value/histogram_unittest.py b/tracing/tracing/value/histogram_unittest.py
index 760cf8639437f429d35380aaeb8b804434b41fb2..015060ff9b55fd6e0543bb79b6c144e356907a6b 100644
--- a/tracing/tracing/value/histogram_unittest.py
+++ b/tracing/tracing/value/histogram_unittest.py
@@ -797,64 +797,6 @@ class TelemetryInfoUnittest(unittest.TestCase):
self.assertNotEqual(info0, info1)
-class DeviceInfoUnittest(unittest.TestCase):
- def testRoundtrip(self):
- info = histogram.DeviceInfo()
- info.chrome_version = '1.2.3.4'
- info.os_name = 'linux'
- info.os_version = '5.6.7'
- info.gpu_info = {'some': 'stuff'}
- info.arch = {'more': 'stuff'}
- info.ram = 42
- d = info.AsDict()
- clone = diagnostic.Diagnostic.FromDict(d)
- self.assertEqual(ToJSON(d), ToJSON(clone.AsDict()))
- self.assertEqual(clone.chrome_version, '1.2.3.4')
- self.assertEqual(clone.os_name, 'linux')
- self.assertEqual(clone.os_version, '5.6.7')
- self.assertEqual(clone.gpu_info['some'], 'stuff')
- self.assertEqual(clone.arch['more'], 'stuff')
- self.assertEqual(clone.ram, 42)
-
- def testEquality(self):
- info0 = histogram.DeviceInfo()
- info0.chrome_version = '1.2.3.4'
- info0.os_name = 'linux'
- info0.os_version = '5.6.7'
- info0.gpu_info = {'some': 'stuff'}
- info0.arch = {'more': 'stuff'}
- info0.ram = 42
- info0.guid = 'abc'
- info1 = histogram.DeviceInfo()
- info1.chrome_version = '1.2.3.4'
- info1.os_name = 'linux'
- info1.os_version = '5.6.7'
- info1.gpu_info = {'some': 'stuff'}
- info1.arch = {'more': 'stuff'}
- info1.ram = 42
- info1.guid = 'def'
- self.assertEqual(info0, info1)
-
- def testInequality(self):
- info0 = histogram.DeviceInfo()
- info0.chrome_version = '1.2.3.4'
- info0.os_name = 'linux'
- info0.os_version = '5.6.7'
- info0.gpu_info = {'some': 'stuff'}
- info0.arch = {'more': 'stuff'}
- info0.ram = 42
- info0.guid = 'abc'
- info1 = histogram.DeviceInfo()
- info1.chrome_version = '1.2.3.4'
- info1.os_name = 'mac'
- info1.os_version = '5.6.7'
- info1.gpu_info = {'some': 'stuff'}
- info1.arch = {'more': 'stuff'}
- info1.ram = 42
- info1.guid = 'def'
- self.assertNotEqual(info0, info1)
-
-
class RelatedEventSetUnittest(unittest.TestCase):
def testRoundtrip(self):
events = histogram.RelatedEventSet()
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/ui/device_info_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698