Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: dashboard/dashboard/add_histograms_test.py

Issue 2988823002: DeviceInfo into GenericSets (Closed)
Patch Set: Remove how-to-write-metrics-device image Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/add_histograms.py ('k') | docs/histogram-set-json-format.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/add_histograms_test.py
diff --git a/dashboard/dashboard/add_histograms_test.py b/dashboard/dashboard/add_histograms_test.py
index 90133be2428e115721ece67ff1a555aa262c7beb..1d5c9dbb8459b77d8a5077dfeb9857a28963f8dc 100644
--- a/dashboard/dashboard/add_histograms_test.py
+++ b/dashboard/dashboard/add_histograms_test.py
@@ -585,9 +585,14 @@ class AddHistogramsTest(testing_common.TestCase):
def testDeduplicateAndPut_Same(self):
d = {
- 'guid': 'abc',
- 'osName': 'linux',
- 'type': 'DeviceInfo'
+ 'buildNumber': 0,
+ 'buildbotMasterName': '',
+ 'buildbotName': '',
+ 'displayBotName': 'bot',
+ 'displayMasterName': 'master',
+ 'guid': 'e9c2891d-2b04-413f-8cf4-099827e67626',
+ 'logUri': '',
+ 'type': 'BuildbotInfo'
}
test_key = utils.TestKey('Chromium/win7/foo')
entity = histogram.SparseDiagnostic(
@@ -605,9 +610,14 @@ class AddHistogramsTest(testing_common.TestCase):
def testDeduplicateAndPut_Different(self):
d = {
- 'guid': 'abc',
- 'osName': 'linux',
- 'type': 'DeviceInfo'
+ 'buildNumber': 0,
+ 'buildbotMasterName': '',
+ 'buildbotName': '',
+ 'displayBotName': 'bot',
+ 'displayMasterName': 'master',
+ 'guid': 'e9c2891d-2b04-413f-8cf4-099827e67626',
+ 'logUri': '',
+ 'type': 'BuildbotInfo'
}
test_key = utils.TestKey('Chromium/win7/foo')
entity = histogram.SparseDiagnostic(
@@ -616,7 +626,7 @@ class AddHistogramsTest(testing_common.TestCase):
entity.put()
d2 = d.copy()
d2['guid'] = 'def'
- d2['osName'] = 'mac'
+ d2['displayBotName'] = 'mac'
entity2 = histogram.SparseDiagnostic(
data=d2, test=test_key,
start_revision=1, end_revision=sys.maxint, id='def')
@@ -626,9 +636,14 @@ class AddHistogramsTest(testing_common.TestCase):
def testDeduplicateAndPut_New(self):
d = {
- 'guid': 'abc',
- 'osName': 'linux',
- 'type': 'DeviceInfo'
+ 'buildNumber': 0,
+ 'buildbotMasterName': '',
+ 'buildbotName': '',
+ 'displayBotName': 'bot',
+ 'displayMasterName': 'master',
+ 'guid': 'e9c2891d-2b04-413f-8cf4-099827e67626',
+ 'logUri': '',
+ 'type': 'BuildbotInfo'
}
test_key = utils.TestKey('Chromium/win7/foo')
entity = histogram.SparseDiagnostic(
« no previous file with comments | « dashboard/dashboard/add_histograms.py ('k') | docs/histogram-set-json-format.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698