Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: docs/how-to-write-metrics.md

Issue 2988823002: DeviceInfo into GenericSets (Closed)
Patch Set: Rebase and fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/how-to-write-metrics.md
diff --git a/docs/how-to-write-metrics.md b/docs/how-to-write-metrics.md
index a2487855fb5d0d7a9a24beaab088a132ce368297..d5a0e51d3187ad1f53c3f30917b9dc467862eb82 100644
--- a/docs/how-to-write-metrics.md
+++ b/docs/how-to-write-metrics.md
@@ -188,15 +188,6 @@ histogram.addSample(number, {name: diagnostic})
![](/docs/images/how-to-write-metrics-telemetry.png)
- * [DeviceInfo](/tracing/tracing/value/diagnostics/device_info.html):
- This is automatically attached to every Histogram produced by buildbots.
- Structurally, it's a class with explicit named fields. Conceptually, it
- contains information about the machine that produced the trace that was
- consumed by the metric that produced the Histogram, such as the OS version,
- Chrome version, etc. Visually, DeviceInfos are displayed as a table.
-
- ![](/docs/images/how-to-write-metrics-device.png)
benjhayden 2017/07/26 05:24:13 Can you git rm this image file as well?
-
* [RevisionInfo](/tracing/tracing/value/diagnostics/revision_info.html):
This is automatically attached to every Histogram produced by telemetry.
Structurally, it's a class with explicit named fields. Conceptually, it
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698