dashboard/dashboard/add_histograms.py - Issue 2988823002: DeviceInfo into GenericSets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/add_histograms.py

Issue 2988823002: DeviceInfo into GenericSets (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/add_histograms.py

diff --git a/dashboard/dashboard/add_histograms.py b/dashboard/dashboard/add_histograms.py

index 84ae9bb36e4092753a7436be475447241c77c8bb..cba047b9e978dbffb625440f7c1135a53a89ef1a 100644

--- a/dashboard/dashboard/add_histograms.py

+++ b/dashboard/dashboard/add_histograms.py

@@ -21,9 +21,10 @@ from tracing.value.diagnostics import diagnostic

from tracing.value.diagnostics import reserved_infos

# TODO(#3718): Use names along with types to create sparse diagnostics, add here

-# owners and bug components as sparse level diagnostics

+# owners and bug components as sparse level diagnostics. Do the same for the

+# diagnostics describing device information.

SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(

- [histogram_module.BuildbotInfo, histogram_module.DeviceInfo])

+ [histogram_module.BuildbotInfo])

HISTOGRAM_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(

[histogram_module.TelemetryInfo])

SPARSE_DIAGNOSTIC_TYPES = SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES.union(