Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2988803002: Adjust some tests for limited 64-bit integers (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, siva, bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust some tests for limited 64-bit integers In preparation for limiting Dart integers to 64 bits, certain tests are corrected to avoid large integer literal or computations with overflow. R=zra@google.com Issue: https://github.com/dart-lang/sdk/issues/30103 Committed: https://github.com/dart-lang/sdk/commit/277f22329fa0de2c682d263038033f8015159740

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M tests/corelib/growable_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/hash_set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/growable_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/hash_set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/bit_shift_test.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M tests/language/list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/integer_type_propagation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/regress_25335_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-25 20:11:03 UTC) #2
zra
lgtm
3 years, 5 months ago (2017-07-25 20:15:39 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-25 20:19:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
277f22329fa0de2c682d263038033f8015159740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698