Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 298873006: [Telemetry] Improve Android cycle time. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
dtu, qsr
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Improve Android cycle time. There's no need to eagerly install the file_poller. This ensure we only do it when we're running a measurement that needs it. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272575

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 12 (0 generated)
tonyg
6 years, 7 months ago (2014-05-22 22:25:54 UTC) #1
qsr
https://codereview.chromium.org/298873006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/298873006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode46 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:46: self._device, 'file_poller') Do you want to cache that you ...
6 years, 7 months ago (2014-05-23 09:15:36 UTC) #2
tonyg
https://codereview.chromium.org/298873006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/298873006/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode46 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:46: self._device, 'file_poller') On 2014/05/23 09:15:36, qsr wrote: > Do ...
6 years, 7 months ago (2014-05-23 13:33:17 UTC) #3
qsr
lgtm
6 years, 7 months ago (2014-05-23 13:45:17 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-23 13:48:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/298873006/1
6 years, 7 months ago (2014-05-23 13:48:59 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 16:03:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 16:05:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/7283)
6 years, 7 months ago (2014-05-23 16:05:43 UTC) #9
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 7 months ago (2014-05-23 16:48:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/298873006/1
6 years, 7 months ago (2014-05-23 16:50:24 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 19:03:33 UTC) #12
Message was sent while issue was closed.
Change committed as 272575

Powered by Google App Engine
This is Rietveld 408576698