Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove more asserts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGAnimatedProperty.cpp
diff --git a/Source/core/svg/properties/SVGAnimatedProperty.cpp b/Source/core/svg/properties/SVGAnimatedProperty.cpp
index 9406d2c32fe1ee55e78d81ac4a011cd1148abd64..3547d6ea47c04d991ef0bf0a27284a537a45cb77 100644
--- a/Source/core/svg/properties/SVGAnimatedProperty.cpp
+++ b/Source/core/svg/properties/SVGAnimatedProperty.cpp
@@ -38,7 +38,6 @@ namespace WebCore {
SVGAnimatedPropertyBase::SVGAnimatedPropertyBase(AnimatedPropertyType type, SVGElement* contextElement, const QualifiedName& attributeName)
: m_type(type)
, m_isReadOnly(false)
- , m_isAnimating(false)
, m_contextElement(contextElement)
, m_attributeName(attributeName)
{
@@ -51,29 +50,20 @@ SVGAnimatedPropertyBase::SVGAnimatedPropertyBase(AnimatedPropertyType type, SVGE
SVGAnimatedPropertyBase::~SVGAnimatedPropertyBase()
{
- // FIXME: Oilpan: We need to investigate why this assert fails in
- // Oilpan builds.
-#if !ENABLE(OILPAN)
- ASSERT(!isAnimating());
-#endif
}
void SVGAnimatedPropertyBase::animationStarted()
{
- ASSERT(!isAnimating());
- m_isAnimating = true;
+ // FIXME: remove this function and its overrides
}
void SVGAnimatedPropertyBase::animationEnded()
{
synchronizeAttribute();
- ASSERT(isAnimating());
- m_isAnimating = false;
}
void SVGAnimatedPropertyBase::synchronizeAttribute()
{
- ASSERT(needsSynchronizeAttribute());
AtomicString value(currentValueBase()->valueAsString());
m_contextElement->setSynchronizedLazyAttribute(m_attributeName, value);
}
« no previous file with comments | « Source/core/svg/properties/SVGAnimatedProperty.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698