LayoutTests/svg/dom/remove-use-target-element-indirectly.html - Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements|

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/dom/remove-use-target-element-indirectly.html

Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements| (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: remove_unused_line Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <script src="../../resources/js-test.js"></script>
	esprehn 2014/05/23 04:38:17 Missing <!DOCTYPE html> Missing <!DOCTYPE html> kouhei (in TOK) 2014/05/23 07:17:15 Done. Show quoted text On 2014/05/23 04:38:17, esprehn wrote: > Missing <!DOCTYPE html> Done.
	2 <script>

	3 jsTestIsAsync = true;

	4 description("Removing animated use target indirectly from the document should no t cause crash.");

	5

	6 function loadedSVGToBeMoved()

	7 {

	8 debug("loaded SVG to be moved");

	9

	10 moveFromOtherToLocal();

	11 }

	12

	13 var count = 0;

	14 function moveFromOtherToLocal()

	15 {

	16 if (++count > 3)

	17 finishJSTest();

	18

	19 var source = document.getElementById("otherWindow").contentDocument;

	20 var defs = source.getElementById("defs");

	21

	22 var target = document.getElementById("localWindow");

	23 target.appendChild(defs);

	24

	25 debug("other -> local");

	26

	27 setTimeout(moveFromLocalToOther, 0);
	esprehn 2014/05/23 04:38:17 What are you waiting for? I think you want request What are you waiting for? I think you want requestAnimationFrame? kouhei (in TOK) 2014/05/23 07:17:15 Done. Show quoted text On 2014/05/23 04:38:17, esprehn wrote: > What are you waiting for? I think you want requestAnimationFrame? Done.
	28 }

	29

	30 function moveFromLocalToOther()

	31 {

	32 var source = document.getElementById("localWindow");

	33 var defs = source.getElementById("defs");

	34

	35 var target = document.getElementById("otherWindow").contentDocument.document Element;

	36 target.appendChild(defs);

	37

	38 debug("local -> other");

	39

	40 setTimeout(moveFromOtherToLocal, 0);
	esprehn 2014/05/23 04:38:17 setTimeout is suspect, you probably want something setTimeout is suspect, you probably want something more explicit. kouhei (in TOK) 2014/05/23 07:17:15 Done. Show quoted text On 2014/05/23 04:38:17, esprehn wrote: > setTimeout is suspect, you probably want something more explicit. Done.
	41 }

	42 </script>

	43 <iframe id="otherWindow" src="resources/svg-with-animate-use.svg" onload="loaded SVGToBeMoved()"></iframe>

	44 <svg id="localWindow">

	45 <use xlink:href="#template" />

	46 </svg>

	47 <p>Test pass if no crash.</p>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/dom/remove-use-target-element-indirectly-expected.txt » ('j') | Source/core/svg/SVGDocumentExtensions.cpp » ('J')