SVG: SVGAnimateElement should not cache |m_animatedElements|

Source/core/svg/properties/SVGAnimatedProperty.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
 G*     * Redistributions in binary form must reproduce the above
@@ skipping 32 matching lines @@
 
 namespace WebCore {
 
 class SVGElement;
 
 class SVGAnimatedPropertyBase : public RefCounted<SVGAnimatedPropertyBase> {
 public:
     virtual ~SVGAnimatedPropertyBase();
 
     virtual SVGPropertyBase* currentValueBase() = 0;
+    virtual bool isAnimating() const = 0;
 
     virtual void animationStarted();
     virtual PassRefPtr<SVGPropertyBase> createAnimatedValue() = 0;
     virtual void setAnimatedValue(PassRefPtr<SVGPropertyBase>) = 0;
     virtual void animationEnded();
 
     virtual bool needsSynchronizeAttribute() = 0;
     virtual void synchronizeAttribute();
 
     AnimatedPropertyType type() const
     {
         return m_type;
     }
 
     SVGElement* contextElement() const
     {
         return m_contextElement;
     }
 
     const QualifiedName& attributeName() const
     {
         return m_attributeName;
     }
 
-    bool isAnimating() const
-    {
-        return m_isAnimating;
-    }
-
     bool isReadOnly() const
     {
         return m_isReadOnly;
     }
 
     void setReadOnly()
     {
         m_isReadOnly = true;
     }
 
     bool isSpecified() const;
 
 protected:
     SVGAnimatedPropertyBase(AnimatedPropertyType, SVGElement*, const QualifiedName& attributeName);
 
 private:
     const AnimatedPropertyType m_type;
     bool m_isReadOnly;
-    bool m_isAnimating;
 
     // This reference is kept alive from V8 wrapper
     SVGElement* m_contextElement;
 
     const QualifiedName& m_attributeName;
 
     WTF_MAKE_NONCOPYABLE(SVGAnimatedPropertyBase);
 };
 
 template <typename Property>
@@ skipping 12 matching lines @@
     const Property* currentValue() const
     {
         return const_cast<SVGAnimatedPropertyCommon*>(this)->currentValue();
     }
 
     virtual SVGPropertyBase* currentValueBase() OVERRIDE
     {
         return currentValue();
     }
 
+    virtual bool isAnimating() const OVERRIDE
+    {
+        return m_currentValue;
+    }
+
     void setBaseValueAsString(const String& value, SVGParsingError& parseError)
     {
         TrackExceptionState es;
 
         m_baseValue->setValueAsString(value, es);
 
         if (es.hadException())
             parseError = ParsingAttributeFailedError;
     }
 
     virtual PassRefPtr<SVGPropertyBase> createAnimatedValue() OVERRIDE
     {
         return m_baseValue->clone();
     }
 
     virtual void setAnimatedValue(PassRefPtr<SVGPropertyBase> passValue) OVERRIDE
     {
-        ASSERT(isAnimating());
-
         RefPtr<SVGPropertyBase> value = passValue;
         ASSERT(value->type() == Property::classType());
         m_currentValue = static_pointer_cast<Property>(value.release());
     }
 
     virtual void animationEnded() OVERRIDE
     {
-        ASSERT(m_currentValue);
         m_currentValue.clear();
 
         SVGAnimatedPropertyBase::animationEnded();
     }
 
 protected:
     SVGAnimatedPropertyCommon(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<Property> initialValue)
         : SVGAnimatedPropertyBase(Property::classType(), contextElement, attributeName)
         , m_baseValue(initialValue)
     {
@@ skipping 134 matching lines @@
     // When animated:
     //     m_animValTearOff targets m_currentValue.
     //     m_baseValTearOff targets m_baseValue.
     RefPtr<TearOffType> m_baseValTearOff;
     RefPtr<TearOffType> m_animValTearOff;
 };
 
 }
 
 #endif // SVGAnimatedProperty_h