Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Side by Side Diff: Source/core/svg/SVGStaticStringList.h

Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove more asserts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimatedTypeAnimator.h ('k') | Source/core/svg/SVGStaticStringList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 public: 44 public:
45 static PassRefPtr<SVGStaticStringList> create(SVGElement* contextElement, co nst QualifiedName& attributeName) 45 static PassRefPtr<SVGStaticStringList> create(SVGElement* contextElement, co nst QualifiedName& attributeName)
46 { 46 {
47 return adoptRef(new SVGStaticStringList(contextElement, attributeName)); 47 return adoptRef(new SVGStaticStringList(contextElement, attributeName));
48 } 48 }
49 49
50 virtual ~SVGStaticStringList(); 50 virtual ~SVGStaticStringList();
51 51
52 // SVGAnimatedPropertyBase: 52 // SVGAnimatedPropertyBase:
53 virtual SVGPropertyBase* currentValueBase() OVERRIDE; 53 virtual SVGPropertyBase* currentValueBase() OVERRIDE;
54 virtual bool isAnimating() const OVERRIDE;
54 virtual void animationStarted() OVERRIDE; 55 virtual void animationStarted() OVERRIDE;
55 virtual PassRefPtr<SVGPropertyBase> createAnimatedValue() OVERRIDE; 56 virtual PassRefPtr<SVGPropertyBase> createAnimatedValue() OVERRIDE;
56 virtual void setAnimatedValue(PassRefPtr<SVGPropertyBase>) OVERRIDE; 57 virtual void setAnimatedValue(PassRefPtr<SVGPropertyBase>) OVERRIDE;
57 virtual void animationEnded() OVERRIDE; 58 virtual void animationEnded() OVERRIDE;
58 virtual bool needsSynchronizeAttribute() OVERRIDE; 59 virtual bool needsSynchronizeAttribute() OVERRIDE;
59 60
60 void setBaseValueAsString(const String& value, SVGParsingError& parseError); 61 void setBaseValueAsString(const String& value, SVGParsingError& parseError);
61 62
62 SVGStringList* value() { return m_value.get(); } 63 SVGStringList* value() { return m_value.get(); }
63 SVGStringListTearOff* tearOff(); 64 SVGStringListTearOff* tearOff();
64 65
65 private: 66 private:
66 SVGStaticStringList(SVGElement*, const QualifiedName&); 67 SVGStaticStringList(SVGElement*, const QualifiedName&);
67 68
68 RefPtr<SVGStringList> m_value; 69 RefPtr<SVGStringList> m_value;
69 RefPtr<SVGStringListTearOff> m_tearOff; 70 RefPtr<SVGStringListTearOff> m_tearOff;
70 }; 71 };
71 72
72 } 73 }
73 74
74 #endif 75 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimatedTypeAnimator.h ('k') | Source/core/svg/SVGStaticStringList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698