Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Side by Side Diff: Source/core/svg/SVGStaticStringList.cpp

Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove more asserts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGStaticStringList.h ('k') | Source/core/svg/properties/SVGAnimatedProperty.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 SVGStaticStringList::~SVGStaticStringList() 43 SVGStaticStringList::~SVGStaticStringList()
44 { 44 {
45 } 45 }
46 46
47 SVGPropertyBase* SVGStaticStringList::currentValueBase() 47 SVGPropertyBase* SVGStaticStringList::currentValueBase()
48 { 48 {
49 return m_value.get(); 49 return m_value.get();
50 } 50 }
51 51
52 bool SVGStaticStringList::isAnimating() const
53 {
54 return false;
55 }
56
52 void SVGStaticStringList::animationStarted() 57 void SVGStaticStringList::animationStarted()
53 { 58 {
54 ASSERT_NOT_REACHED(); 59 ASSERT_NOT_REACHED();
55 } 60 }
56 61
57 PassRefPtr<SVGPropertyBase> SVGStaticStringList::createAnimatedValue() 62 PassRefPtr<SVGPropertyBase> SVGStaticStringList::createAnimatedValue()
58 { 63 {
59 ASSERT_NOT_REACHED(); 64 ASSERT_NOT_REACHED();
60 return nullptr; 65 return nullptr;
61 } 66 }
(...skipping 25 matching lines...) Expand all
87 { 92 {
88 TrackExceptionState es; 93 TrackExceptionState es;
89 94
90 m_value->setValueAsString(value, es); 95 m_value->setValueAsString(value, es);
91 96
92 if (es.hadException()) 97 if (es.hadException())
93 parseError = ParsingAttributeFailedError; 98 parseError = ParsingAttributeFailedError;
94 } 99 }
95 100
96 } 101 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGStaticStringList.h ('k') | Source/core/svg/properties/SVGAnimatedProperty.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698