Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Side by Side Diff: Source/core/svg/SVGAnimatedAngle.cpp

Issue 298873003: SVG: SVGAnimateElement should not cache |m_animatedElements| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove more asserts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 , m_orientType(SVGAnimatedEnumeration<SVGMarkerOrientType>::create(contextEl ement, SVGNames::orientAttr, baseValue()->orientType())) 42 , m_orientType(SVGAnimatedEnumeration<SVGMarkerOrientType>::create(contextEl ement, SVGNames::orientAttr, baseValue()->orientType()))
43 { 43 {
44 } 44 }
45 45
46 SVGAnimatedAngle::~SVGAnimatedAngle() 46 SVGAnimatedAngle::~SVGAnimatedAngle()
47 { 47 {
48 } 48 }
49 49
50 void SVGAnimatedAngle::synchronizeAttribute() 50 void SVGAnimatedAngle::synchronizeAttribute()
51 { 51 {
52 ASSERT(needsSynchronizeAttribute());
53
54 AtomicString value; 52 AtomicString value;
55 if (m_orientType->currentValue()->enumValue() == SVGMarkerOrientAuto) 53 if (m_orientType->currentValue()->enumValue() == SVGMarkerOrientAuto)
56 value = "auto"; 54 value = "auto";
57 else 55 else
58 value = AtomicString(currentValue()->valueAsString()); 56 value = AtomicString(currentValue()->valueAsString());
59 57
60 contextElement()->setSynchronizedLazyAttribute(attributeName(), value); 58 contextElement()->setSynchronizedLazyAttribute(attributeName(), value);
61 } 59 }
62 60
63 void SVGAnimatedAngle::animationStarted() 61 void SVGAnimatedAngle::animationStarted()
64 { 62 {
65 SVGAnimatedProperty<SVGAngle>::animationStarted(); 63 SVGAnimatedProperty<SVGAngle>::animationStarted();
66 m_orientType->animationStarted(); 64 m_orientType->animationStarted();
67 } 65 }
68 66
69 void SVGAnimatedAngle::setAnimatedValue(PassRefPtr<SVGPropertyBase> value) 67 void SVGAnimatedAngle::setAnimatedValue(PassRefPtr<SVGPropertyBase> value)
70 { 68 {
71 SVGAnimatedProperty<SVGAngle>::setAnimatedValue(value); 69 SVGAnimatedProperty<SVGAngle>::setAnimatedValue(value);
72 m_orientType->setAnimatedValue(currentValue()->orientType()); 70 m_orientType->setAnimatedValue(currentValue()->orientType());
73 } 71 }
74 72
75 void SVGAnimatedAngle::animationEnded() 73 void SVGAnimatedAngle::animationEnded()
76 { 74 {
77 SVGAnimatedProperty<SVGAngle>::animationEnded(); 75 SVGAnimatedProperty<SVGAngle>::animationEnded();
78 m_orientType->animationEnded(); 76 m_orientType->animationEnded();
79 } 77 }
80 78
81 } 79 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | Source/core/svg/SVGAnimatedInteger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698