Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: tests/corelib_2/string_replace_test.dart

Issue 2988673003: fix override checking of mixins (Closed)
Patch Set: update status Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/corelib_2/corelib_2.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib_2/string_replace_test.dart
diff --git a/tests/corelib_2/string_replace_test.dart b/tests/corelib_2/string_replace_test.dart
index 4599c6e1ffb37e3ee79eb10edb860544b2b5bf02..65e59e60c16cea46b871ff396c4bf86a056c0f76 100644
--- a/tests/corelib_2/string_replace_test.dart
+++ b/tests/corelib_2/string_replace_test.dart
@@ -175,7 +175,10 @@ main() {
Expect.equals(
"foo-$o",
"foo-bar".replaceFirstMapped("bar", (v) {
- return o;
+ // TODO(jmesserly): in strong mode, this function must return a string.
+ // If we want to allow any Object, we'll have to fix the API signature.
+ // See https://github.com/dart-lang/sdk/issues/30248.
+ return '$o';
}));
for (var string in ["", "x", "foo", "x\u2000z"]) {
« no previous file with comments | « tests/corelib_2/corelib_2.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698