Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2988673003: fix override checking of mixins (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly
Modified:
3 years, 5 months ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix override checking of mixins it was rejecting some patterns that are sound, because the mixin member is overridden and thus not exposed. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/ff8511c83efd77c498ca83d5ded70c0d16609729

Patch Set 1 #

Total comments: 1

Patch Set 2 : update status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -37 lines) Patch
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +30 lines, -21 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 3 chunks +22 lines, -13 lines 0 comments Download
M pkg/dev_compiler/test/compile_error_tests.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_2/corelib_2.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib_2/string_replace_test.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/2988673003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart File pkg/analyzer/lib/src/task/strong/checker.dart (right): https://codereview.chromium.org/2988673003/diff/1/pkg/analyzer/lib/src/task/strong/checker.dart#newcode1668 pkg/analyzer/lib/src/task/strong/checker.dart:1668: /// Checks that most-derived concrete members on this class ...
3 years, 5 months ago (2017-07-24 20:25:40 UTC) #2
Leaf
lgtm
3 years, 5 months ago (2017-07-24 20:32:53 UTC) #3
Jennifer Messerly
3 years, 5 months ago (2017-07-24 23:27:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ff8511c83efd77c498ca83d5ded70c0d16609729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698