Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: tools/telemetry/telemetry/page/cloud_storage.py

Issue 298863016: Adds extra logging to telemetry in hope it helps diagnose issue 351143 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_archive_info.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/cloud_storage.py
diff --git a/tools/telemetry/telemetry/page/cloud_storage.py b/tools/telemetry/telemetry/page/cloud_storage.py
index 4eb0745540a41e311fc6debcc85177e5f2d07b26..726efdf1a86f7c2d374d88474b6521f654732963 100644
--- a/tools/telemetry/telemetry/page/cloud_storage.py
+++ b/tools/telemetry/telemetry/page/cloud_storage.py
@@ -176,10 +176,12 @@ def GetIfChanged(file_path, bucket=None):
"""
hash_path = file_path + '.sha1'
if not os.path.exists(hash_path):
+ logging.warning('Hash file not found: %s' % hash_path)
return False
expected_hash = ReadHash(hash_path)
if os.path.exists(file_path) and CalculateHash(file_path) == expected_hash:
+ logging.info('File up to date: %s' % file_path)
return False
if bucket:
@@ -191,6 +193,7 @@ def GetIfChanged(file_path, bucket=None):
for bucket in buckets:
try:
url = 'gs://%s/%s' % (bucket, expected_hash)
+ logging.info('Running gsutil command: cp %s %s' % (url, file_path))
_RunCommand(['cp', url, file_path])
logging.info('Downloaded %s to %s' % (url, file_path))
found = True
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_archive_info.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698