Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 298863016: Adds extra logging to telemetry in hope it helps diagnose issue 351143 (Closed)

Created:
6 years, 7 months ago by tbarzic
Modified:
6 years, 7 months ago
Reviewers:
achuithb, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Adds extra logging to telemetry in hope it helps diagnose issue 351143 It seems there is a problem running gsutil on cros dtus, so adding few extra log statements around that code. BUG=351143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272838

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M tools/telemetry/telemetry/page/cloud_storage.py View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 1 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tbarzic
Can you take a look at this? Hope it makes sense.. warning: I have almost ...
6 years, 7 months ago (2014-05-23 21:26:48 UTC) #1
achuithb
lgtm https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py#newcode179 tools/telemetry/telemetry/page/cloud_storage.py:179: logging.warning('Hash file not found: %s' % hash_path) You ...
6 years, 7 months ago (2014-05-23 21:33:34 UTC) #2
tbarzic
https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py#newcode179 tools/telemetry/telemetry/page/cloud_storage.py:179: logging.warning('Hash file not found: %s' % hash_path) On 2014/05/23 ...
6 years, 7 months ago (2014-05-23 21:38:14 UTC) #3
achuithb
https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py File tools/telemetry/telemetry/page/cloud_storage.py (right): https://codereview.chromium.org/298863016/diff/1/tools/telemetry/telemetry/page/cloud_storage.py#newcode179 tools/telemetry/telemetry/page/cloud_storage.py:179: logging.warning('Hash file not found: %s' % hash_path) On 2014/05/23 ...
6 years, 7 months ago (2014-05-23 21:39:11 UTC) #4
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 7 months ago (2014-05-25 21:30:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/298863016/20001
6 years, 7 months ago (2014-05-25 21:30:53 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:09:33 UTC) #7
Message was sent while issue was closed.
Change committed as 272838

Powered by Google App Engine
This is Rietveld 408576698