Use upstream libaddressinput in Chrome.

third_party/libaddressinput/chromium/chrome_storage_impl.h

Index: third_party/libaddressinput/chromium/chrome_storage_impl.h
diff --git a/third_party/libaddressinput/chromium/chrome_storage_impl.h b/third_party/libaddressinput/chromium/chrome_storage_impl.h
index 5ee657b139c96000c994679558875f71f8374420..1c1cfb2645c3cd4a05db453811456841a56d3a0c 100644
--- a/third_party/libaddressinput/chromium/chrome_storage_impl.h
+++ b/third_party/libaddressinput/chromium/chrome_storage_impl.h
@@ -11,8 +11,7 @@
 #include "base/memory/scoped_vector.h"
 #include "base/prefs/pref_store.h"
 #include "base/scoped_observer.h"
-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h"
-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/scoped_ptr.h"
+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/storage.h"
 
 class WriteablePrefStore;
 
@@ -28,9 +27,8 @@ class ChromeStorageImpl : public ::i18n::addressinput::Storage,
   virtual ~ChromeStorageImpl();
 
   // ::i18n::addressinput::Storage implementation.
-  virtual void Put(const std::string& key, scoped_ptr<std::string> data)
-      OVERRIDE;
-  virtual void Get(const std::string& key, scoped_ptr<Callback> data_ready)
+  virtual void Put(const std::string& key, const std::string& data) OVERRIDE;

[Evan Stade, 2014/06/12 00:18:09]

why add a copy operation

[please use gerrit instead, 2014/06/13 19:22:09]

I don't think switching from scoped_ptr::Pass() to const-ref is much of an
impact. If you want to switch to scoped_ptr::Pass(), I can submit a patch to
https://code.google.com/p/libaddressinput/ after this patch lands.

[Evan Stade, 2014/06/13 20:07:08]

I think you should fix upstream before landing this patch, because it would
greatly reduce the size of this patch

+  virtual void Get(const std::string& key, const Callback& data_ready)
       const OVERRIDE;
 
   // PrefStore::Observer implementation.
@@ -39,14 +37,14 @@ class ChromeStorageImpl : public ::i18n::addressinput::Storage,
 
  private:
   struct Request {
-    Request(const std::string& key, scoped_ptr<Callback> callback);
+    Request(const std::string& key, const Callback& callback);
 
     std::string key;
-    scoped_ptr<Callback> callback;
+    const Callback& callback;
   };
 
   // Non-const version of Get().
-  void DoGet(const std::string& key, scoped_ptr<Callback> data_ready);
+  void DoGet(const std::string& key, const Callback& data_ready);
 
   WriteablePrefStore* backing_store_;  // weak