Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Work in progress for suggestions impl. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
index bfab9eaeaaec83429b97ae4dda2a01c3d9a14690..fdf926756c36ee29352386688ebd9eb5b6de003e 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
@@ -6,7 +6,7 @@
#include "components/autofill/core/browser/field_types.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h"
+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui.h"
namespace autofill {
namespace i18ninput {
@@ -78,7 +78,11 @@ TEST(AutofillDialogI18nInput, FullySupportedCountries) {
const std::vector<std::string>& regions =
::i18n::addressinput::GetRegionCodes();
for (size_t i = 0; i < regions.size(); ++i) {
- bool should_be_supported = !(regions[i] == "KR" || regions[i] == "CN");
+ // TODO(rouslan): Support dependent locality. http://crbug.com/340929
+ bool should_be_supported = !(regions[i] == "KR" ||
Evan Stade 2014/06/12 00:18:08 you can just leave this alone, it's about to get d
please use gerrit instead 2014/06/13 19:22:09 Done.
+ regions[i] == "CN" ||
+ regions[i] == "MX" ||
+ regions[i] == "TH");
EXPECT_EQ(should_be_supported, CountryIsFullySupported(regions[i]));
}
}

Powered by Google App Engine
This is Rietveld 408576698