third_party/libaddressinput/README.chromium - Issue 298863012: Use upstream libaddressinput in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/README.chromium

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/README.chromium

diff --git a/third_party/libaddressinput/README.chromium b/third_party/libaddressinput/README.chromium

index 13b589868a35272975128a888fc5d12d37a7a96c..be781b736f0922dc99270fb9321e28b83321af43 100644

--- a/third_party/libaddressinput/README.chromium

+++ b/third_party/libaddressinput/README.chromium

@@ -17,9 +17,6 @@ https://i18napis.appspot.com/ssl-aggregate-address. The library is used in

requestAutocomplete dialog and autofill.

Local Modifications:

-- The package is libaddressinput at revision 176 plus the Chrome-specific

- validation logic, which will be upstreamed back to libaddressinput

- (http://crbug.com/327046). The Chrome-specific version is in chromium/cpp/

- subdirectory. The original source code is in src/cpp/ subdirectory. Both

- versions use the original test data file src/testdata/countryinfo.txt.

-- Serbia and Montenegro (YU) was removed as a supported region.

+- Use Chrome's version of JSON reader in chromium/json.cc.

+- Use Chrome's version of loose string comparison in chromium/string_compare.cc.

+- Copy src/cpp/res/messages.grdp to ../../chrome/app/address_input_strings.grdp.

please use gerrit instead 2014/06/05 22:22:48 To reduce reviewer burden: Last line is not necess

please use gerrit instead 2014/06/09 23:28:16 Done.