chrome/browser/ui/autofill/mock_address_validator.cc - Issue 298863012: Use upstream libaddressinput in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/mock_address_validator.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/mock_address_validator.cc

diff --git a/chrome/browser/ui/autofill/mock_address_validator.cc b/chrome/browser/ui/autofill/mock_address_validator.cc

index 3361bea8c49a7f1ffff59bf2d55f0a41355544a2..5840ca86489a1647a5b8799335827bd4eb402120 100644

--- a/chrome/browser/ui/autofill/mock_address_validator.cc

+++ b/chrome/browser/ui/autofill/mock_address_validator.cc

@@ -9,7 +9,8 @@ namespace autofill {

MockAddressValidator::MockAddressValidator() {

using testing::_;

using testing::Return;

- ON_CALL(*this, ValidateAddress(_, _, _)).WillByDefault(Return(SUCCESS));

+ ON_CALL(*this, LoadRules(_, _)).WillByDefault(Return());

please use gerrit instead 2014/06/05 22:22:48 To reduce reviewer burden: Single parameter.

please use gerrit instead 2014/06/09 23:28:16 Done.

+ ON_CALL(*this, Validate(_, _, _)).WillByDefault(Return(SUCCESS));

please use gerrit instead 2014/06/05 22:22:48 To reduce reviewer burden: ValidateAddress.

please use gerrit instead 2014/06/09 23:28:16 Done.

ON_CALL(*this, GetSuggestions(_, _, _, _)).WillByDefault(Return(SUCCESS));

ON_CALL(*this, CanonicalizeAdministrativeArea(_)).WillByDefault(Return(true));

}