Use upstream libaddressinput in Chrome.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index fb92f35cad97b7d2a9061310d15692d5e7a5761e..c9c079b5ada1268e74dc3c53c4ac711d8795edbb 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -8,6 +8,7 @@
 #include <set>
 #include <vector>
 
+#include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ -35,8 +36,7 @@
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/ssl_status.h"
-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h"
-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/load_rules_delegate.h"
+#include "third_party/libaddressinput/chromium/preload_address_validator.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/base/ui_base_types.h"
@@ -50,6 +50,12 @@ namespace content {
 class WebContents;
 }
 
+namespace i18n {
+namespace addressinput {
+struct AddressData;
+}
+}
+
 namespace autofill {
 
 class AutofillDataModel;
@@ -78,8 +84,7 @@ class AutofillDialogControllerImpl
       public wallet::WalletSigninHelperDelegate,
       public PersonalDataManagerObserver,
       public AccountChooserModelDelegate,
-      public gfx::AnimationDelegate,
-      public ::i18n::addressinput::LoadRulesDelegate {

[please use gerrit instead, 2014/06/05 22:22:47]

To reduce reviewer burden: Bring back LoadRulesDelegate, but in autofill
namespace.

+      public gfx::AnimationDelegate {
  public:
   virtual ~AutofillDialogControllerImpl();
 
@@ -218,9 +223,10 @@ class AutofillDialogControllerImpl
   virtual void AnimationEnded(const gfx::Animation* animation) OVERRIDE;
   virtual void AnimationProgressed(const gfx::Animation* animation) OVERRIDE;
 
-  // ::i18n::addressinput::LoadRulesDelegate implementation.
-  virtual void OnAddressValidationRulesLoaded(const std::string& country_code,
-                                              bool success) OVERRIDE;
+  // PreloadAddressValidator::Callback implementation.
+  void AddressValidationRulesLoaded(bool success,
+                                    const std::string& country_code,
+                                    const int& rule_count);
 
  protected:
   enum DialogSignedInState {
@@ -250,7 +256,7 @@ class AutofillDialogControllerImpl
   virtual PersonalDataManager* GetManager() const;
 
   // Returns an address validation helper. May be NULL during tests.
-  virtual ::i18n::addressinput::AddressValidator* GetValidator();
+  virtual PreloadAddressValidator* GetValidator();
 
   // Returns the WalletClient* this class uses to talk to Online Wallet. Exposed
   // for testing.
@@ -654,7 +660,7 @@ class AutofillDialogControllerImpl
   wallet::WalletClient wallet_client_;
 
   // A helper to validate international address input.
-  scoped_ptr< ::i18n::addressinput::AddressValidator> validator_;
+  scoped_ptr<PreloadAddressValidator> validator_;
 
   // True if |this| has ever called GetWalletItems().
   bool wallet_items_requested_;
@@ -833,6 +839,9 @@ class AutofillDialogControllerImpl
 
   base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
 
+  const scoped_ptr<PreloadAddressValidator::Callback>
+      address_validation_rules_loaded_;

[please use gerrit instead, 2014/06/05 22:22:47]

To reduce reviewer burden: Use autofill::LoadRulesDelegate instead of
PreloadAddressValidator::Callback address_validation_rules_loaded_.

+
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };