Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/libaddressinput/README.chromium

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/README.chromium
diff --git a/third_party/libaddressinput/README.chromium b/third_party/libaddressinput/README.chromium
index 990a8ab618f576a6b1e4d4e2917ab8d5809b046d..c7cfaddbda7fa9ba6688b8b55aeaa42b4f7b22ae 100644
--- a/third_party/libaddressinput/README.chromium
+++ b/third_party/libaddressinput/README.chromium
@@ -2,22 +2,22 @@ Name: The library to input and validate addresses.
Short Name: libaddressinput
URL: https://code.google.com/p/libaddressinput/
Version: 0
-Date: 5 December 2013
-Revision: 176
+Date: 23 May 2014
+Revision: 246
License: Apache 2.0
License File: LICENSE
Security Critical: no
Description:
-This library allows users to input their address, and perform validation on this
-by talking to an address data server https://i18napis.appspot.com/ssl-address.
-The library is used in requestAutocomplete() dialog to enable internationalized
-address input and validation for payment forms.
+
+This library lets you enter, validate, and display an address with
+correct semantics for many countries around the world. The library
+uses the serialized validation rules from a Google-managed server
+(without SLA) at https://i18napis.appspot.com/ssl-aggregate-address.
+The library is used in requestAutocomplete dialog and autofill.
Local Modifications:
-- The package is libaddressinput at revision 176 plus the Chrome-specific
- validation logic, which will be upstreamed back to libaddressinput
- (http://crbug.com/327046). The Chrome-specific version is in chromium/cpp/
- subdirectory. The original source code is in src/cpp/ subdirectory. Both
- versions use the original test data file src/testdata/countryinfo.txt.
-- Serbia and Montenegro (YU) was removed as a supported region.
+- Use Chrome's version of JSON reader in chromium/json.cc.
+- Use Chrome's version of the localization object in chromium/localization.cc.
+- Use Chrome's version of loose string comparison in chromium/string_compare.cc.
+- Copy src/cpp/res/messages.grdp to ../../chrome/app/address_input_strings.grdp.

Powered by Google App Engine
This is Rietveld 408576698