chrome/browser/ui/autofill/data_model_wrapper.cc - Issue 298863012: Use upstream libaddressinput in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/data_model_wrapper.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc ('K') | « chrome/browser/ui/autofill/country_combobox_model_unittest.cc ('k') | chrome/browser/ui/autofill/mock_address_validator.h » ('j') | third_party/libaddressinput/chromium/preload_address_validator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/data_model_wrapper.cc

diff --git a/chrome/browser/ui/autofill/data_model_wrapper.cc b/chrome/browser/ui/autofill/data_model_wrapper.cc

index 4d513a2cf0d592773c6f3720a265895300e65ecd..aef605c32bb469077f88835bfac1a7548658c533 100644

--- a/chrome/browser/ui/autofill/data_model_wrapper.cc

+++ b/chrome/browser/ui/autofill/data_model_wrapper.cc

@@ -22,8 +22,8 @@

#include "components/autofill/core/browser/autofill_type.h"

#include "components/autofill/core/browser/credit_card.h"

#include "components/autofill/core/browser/form_structure.h"

-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h"

-#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h"

+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"

+#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui.h"

#include "ui/base/resource/resource_bundle.h"

#include "ui/gfx/image/image.h"

@@ -61,7 +61,7 @@ bool DataModelWrapper::GetDisplayText(

base::Bind(&DataModelWrapper::GetInfo, base::Unretained(this)));

address_data->language_code = GetLanguageCode();

std::vector<std::string> lines;

- address_data->FormatForDisplay(&lines);

+ // address_data->FormatForDisplay(&lines);

please use gerrit instead 2014/05/23 14:44:54 Need to switch to using address_formatter.h in lib

// Email and phone number aren't part of address formatting.

base::string16 non_address_info;

@@ -72,8 +72,9 @@ bool DataModelWrapper::GetDisplayText(

non_address_info += base::ASCIIToUTF16("\n") + phone;

// The separator is locale-specific.

- std::string compact_separator =

- ::i18n::addressinput::GetCompactAddressLinesSeparator(GetLanguageCode());

+ std::string compact_separator = ", ";

+ // ::i18n::addressinput::GetCompactAddressLinesSeparator(

+ // GetLanguageCode());

*vertically_compact =

base::UTF8ToUTF16(JoinString(lines, compact_separator)) +

non_address_info;

@@ -391,7 +392,7 @@ base::string16 I18nAddressDataWrapper::GetInfo(const AutofillType& type) const {

return base::string16();

if (field == ::i18n::addressinput::COUNTRY) {

- return AutofillCountry(address_->country_code,

+ return AutofillCountry(address_->region_code,

g_browser_process->GetApplicationLocale()).name();

}