Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Validate required fields without rules. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc
diff --git a/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc b/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc
index 9da2183716466c069f88cca0b7cf39a6d7164a03..2633d10242b57b8f9f252b44880c26a3ba4a2096 100644
--- a/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc
+++ b/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc
@@ -35,26 +35,30 @@ class ChromeDownloaderImplTest : public testing::Test {
net::TestURLRequestContextGetter* getter =
new net::TestURLRequestContextGetter(base::MessageLoopProxy::current());
ChromeDownloaderImpl impl(getter);
- impl.Download(url_.spec(), BuildCallback());
+ scoped_ptr< ::i18n::addressinput::Downloader::Callback> callback(
+ ::i18n::addressinput::BuildCallback(
+ this, &ChromeDownloaderImplTest::OnDownloaded));
+ impl.Download(url_.spec(), *callback);
base::MessageLoop::current()->RunUntilIdle();
}
void set_url(const GURL& url) { url_ = url; }
- const std::string& data() { return *data_; }
- bool success() { return success_; }
+ bool success() const { return success_; }
+ bool has_data() const { return !!data_; }
- private:
- scoped_ptr<ChromeDownloaderImpl::Callback> BuildCallback() {
- return ::i18n::addressinput::BuildScopedPtrCallback(
- this, &ChromeDownloaderImplTest::OnDownloaded);
+ const std::string& data() const {
+ DCHECK(data_);
+ return *data_;
}
+ private:
// Callback for when download is finished.
void OnDownloaded(bool success,
const std::string& url,
- scoped_ptr<std::string> data) {
+ std::string* data) {
+ ASSERT_FALSE(success && data == NULL);
success_ = success;
- data_ = data.Pass();
+ data_.reset(data);
}
base::MessageLoop loop_;
@@ -80,7 +84,7 @@ TEST_F(ChromeDownloaderImplTest, Failure) {
SetFakeResponse(kFakePayload, net::HTTP_INTERNAL_SERVER_ERROR);
Download();
EXPECT_FALSE(success());
- EXPECT_EQ(std::string(), data());
+ EXPECT_TRUE(!has_data() || data().empty());
}
TEST_F(ChromeDownloaderImplTest, RejectsInsecureScheme) {
@@ -89,7 +93,7 @@ TEST_F(ChromeDownloaderImplTest, RejectsInsecureScheme) {
SetFakeResponse(kFakePayload, net::HTTP_OK);
Download();
EXPECT_FALSE(success());
- EXPECT_EQ(std::string(), data());
+ EXPECT_TRUE(!has_data() || data().empty());
}
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698