Use upstream libaddressinput in Chrome.

third_party/libaddressinput/chromium/preload_address_validator_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstddef>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
-
-#define I18N_ADDRESSINPUT_UTIL_BASICTYPES_H_
 #include "third_party/libaddressinput/chromium/preload_address_validator.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_field.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_problem.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_validator.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/callback.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/downloader.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/null_storage.h"
 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/storage.h"
 #include "third_party/libaddressinput/src/cpp/src/region_data_constants.h"
@@ skipping 75 matching lines @@
 TEST_F(PreloadAddressValidatorTest, EmptyAddressNoFatalFailure) {
   AddressData address;
   address.region_code = "US";
 
   FieldProblemMap dummy;
   EXPECT_EQ(
       PreloadAddressValidator::SUCCESS,
       validator_->Validate(address, NULL, &dummy));
 }
 
+TEST_F(PreloadAddressValidatorTest, UsStateNamesAreValidEntries) {
+  AddressData address;
+  address.region_code = "US";
+  address.administrative_area = "California";
+
+  FieldProblemMap filter;
+  filter.insert(std::make_pair(ADMIN_AREA, UNKNOWN_VALUE));
+  FieldProblemMap problems;
+  EXPECT_EQ(
+      PreloadAddressValidator::SUCCESS,
+      validator_->Validate(address, &filter, &problems));
+  EXPECT_TRUE(problems.empty());
+}
+
 TEST_F(PreloadAddressValidatorTest, USZipCode) {
   AddressData address;
   address.address_line.push_back("340 Main St.");
   address.locality = "Venice";
   address.administrative_area = "CA";
   address.region_code = "US";
 
   // Valid Californian zip code.
   address.postal_code = "90291";
   FieldProblemMap problems;
@@ skipping 120 matching lines @@
   FieldProblemMap problems;
   EXPECT_EQ(
       PreloadAddressValidator::SUCCESS,
       validator_->Validate(address, NULL, &problems));
 
   ASSERT_EQ(1U, problems.size());
   EXPECT_EQ(UNKNOWN_VALUE, problems.begin()->second);
   EXPECT_EQ(ADMIN_AREA, problems.begin()->first);
 }
 
-TEST_F(PreloadAddressValidatorTest, NoNullSuggestionsCrash) {
-  AddressData address;
-  address.region_code = "US";
-  EXPECT_EQ(PreloadAddressValidator::SUCCESS,
-            validator_->GetSuggestions(address, COUNTRY, 1, NULL));

[please use gerrit instead, 2014/06/05 22:22:49]

Add back this test! Handle NULL in PreloadAddressValdiator::GetSuggestions().

[please use gerrit instead, 2014/06/09 23:28:17]

Done.

-}
-
 TEST_F(PreloadAddressValidatorTest, SuggestAdminAreaForPostalCode) {
   AddressData address;
   address.region_code = "US";
   address.postal_code = "90291";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("CA", suggestions[0].administrative_area);
   EXPECT_EQ("90291", suggestions[0].postal_code);
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestLocalityForPostalCodeWithAdminArea) {
   validator_->LoadRules("TW", *loaded_);
   AddressData address;
   address.region_code = "TW";
   address.postal_code = "515";
   address.administrative_area = "Changhua";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("Dacun Township", suggestions[0].locality);
   EXPECT_EQ("Changhua County", suggestions[0].administrative_area);
   EXPECT_EQ("515", suggestions[0].postal_code);
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestAdminAreaForPostalCodeWithLocality) {
   validator_->LoadRules("TW", *loaded_);
   AddressData address;
   address.region_code = "TW";
   address.postal_code = "515";
   address.locality = "Dacun";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("Dacun Township", suggestions[0].locality);
   EXPECT_EQ("Changhua County", suggestions[0].administrative_area);
   EXPECT_EQ("515", suggestions[0].postal_code);
 }
 
 TEST_F(PreloadAddressValidatorTest, NoSuggestForPostalCodeWithWrongAdminArea) {
   AddressData address;
   address.region_code = "US";
   address.postal_code = "90066";
   address.postal_code = "TX";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
   EXPECT_TRUE(suggestions.empty());
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestForLocality) {
   validator_->LoadRules("CN", *loaded_);
   AddressData address;
   address.region_code = "CN";
   address.locality = "Anqin";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, LOCALITY, 10, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("Anqing Shi", suggestions[0].locality);
-  EXPECT_EQ("ANHUI SHENG", suggestions[0].administrative_area);
+  EXPECT_EQ("Anhui Sheng", suggestions[0].administrative_area);
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestForLocalityAndAdminArea) {
   validator_->LoadRules("CN", *loaded_);
   AddressData address;
   address.region_code = "CN";
   address.locality = "Anqing";
   address.administrative_area = "Anhui";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, LOCALITY, 10, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_TRUE(suggestions[0].dependent_locality.empty());
   EXPECT_EQ("Anqing Shi", suggestions[0].locality);
-  EXPECT_EQ("ANHUI SHENG", suggestions[0].administrative_area);
+  EXPECT_EQ("Anhui Sheng", suggestions[0].administrative_area);
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestForAdminAreaAndLocality) {
   validator_->LoadRules("CN", *loaded_);
   AddressData address;
   address.region_code = "CN";
   address.locality = "Anqing";
   address.administrative_area = "Anhui";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, ADMIN_AREA, 10, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_TRUE(suggestions[0].dependent_locality.empty());
   EXPECT_TRUE(suggestions[0].locality.empty());
-  EXPECT_EQ("ANHUI SHENG", suggestions[0].administrative_area);
+  EXPECT_EQ("Anhui Sheng", suggestions[0].administrative_area);
 }
 
 TEST_F(PreloadAddressValidatorTest, SuggestForDependentLocality) {
   validator_->LoadRules("CN", *loaded_);
   AddressData address;
   address.region_code = "CN";
   address.dependent_locality = "Zongyang";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(
                 address, DEPENDENT_LOCALITY, 10, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("Zongyang Xian", suggestions[0].dependent_locality);
   EXPECT_EQ("Anqing Shi", suggestions[0].locality);
-  EXPECT_EQ("ANHUI SHENG", suggestions[0].administrative_area);
+  EXPECT_EQ("Anhui Sheng", suggestions[0].administrative_area);
 }
 
 TEST_F(PreloadAddressValidatorTest,
        NoSuggestForDependentLocalityWithWrongAdminArea) {
   validator_->LoadRules("CN", *loaded_);
   AddressData address;
   address.region_code = "CN";
   address.dependent_locality = "Zongyang";
   address.administrative_area = "Sichuan Sheng";
+  address.language_code = "zh-Latn";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(
                 address, DEPENDENT_LOCALITY, 10, &suggestions));
   EXPECT_TRUE(suggestions.empty());
 }
 
 TEST_F(PreloadAddressValidatorTest, EmptySuggestionsOverLimit) {
   AddressData address;
@@ skipping 92 matching lines @@
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, ADMIN_AREA, 1, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("강원도", suggestions[0].administrative_area);
 }
 
 TEST_F(PreloadAddressValidatorTest,
        SuggestLatinNameWhenLanguageDiffersAndLatinNameAvailable) {
   validator_->LoadRules("KR", *loaded_);
   AddressData address;
-  address.language_code = "en";
+  address.language_code = "ko-Latn";
   address.region_code = "KR";
   address.postal_code = "210-210";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(PreloadAddressValidator::SUCCESS,
             validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
   ASSERT_EQ(1U, suggestions.size());
   EXPECT_EQ("Gangwon", suggestions[0].administrative_area);
   EXPECT_EQ("210-210", suggestions[0].postal_code);
 }
 
-TEST_F(PreloadAddressValidatorTest, SuggestLatinNameWhenUserInputIsLatin) {
-  validator_->LoadRules("KR", *loaded_);
-  AddressData address;
-  address.language_code = "ko";
-  address.region_code = "KR";
-  address.administrative_area = "Gang";
-
-  std::vector<AddressData> suggestions;
-  EXPECT_EQ(PreloadAddressValidator::SUCCESS,
-            validator_->GetSuggestions(address, ADMIN_AREA, 1, &suggestions));
-  ASSERT_EQ(1U, suggestions.size());
-  EXPECT_EQ("Gangwon", suggestions[0].administrative_area);
-}
-
 TEST_F(PreloadAddressValidatorTest, NoSuggestionsForEmptyAddress) {
   AddressData address;
   address.region_code = "US";
 
   std::vector<AddressData> suggestions;
   EXPECT_EQ(
+      PreloadAddressValidator::SUCCESS,
+      validator_->GetSuggestions(address, POSTAL_CODE, 999, &suggestions));
+  EXPECT_TRUE(suggestions.empty());
+}
+
+TEST_F(PreloadAddressValidatorTest, SuggestionIncludesCountry) {
+  AddressData address;
+  address.region_code = "US";
+  address.postal_code = "90291";
+
+  std::vector<AddressData> suggestions;
+  EXPECT_EQ(PreloadAddressValidator::SUCCESS,
+            validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
+  ASSERT_EQ(1U, suggestions.size());
+  EXPECT_EQ("US", suggestions[0].region_code);
+}
+
+TEST_F(PreloadAddressValidatorTest, InvalidPostalCodeNoSuggestions) {
+  AddressData address;
+  address.region_code = "US";
+  address.postal_code = "0";
+
+  std::vector<AddressData> suggestions;
+  EXPECT_EQ(
       PreloadAddressValidator::SUCCESS,
       validator_->GetSuggestions(address, POSTAL_CODE, 999, &suggestions));
   EXPECT_TRUE(suggestions.empty());
 }
 
-TEST_F(PreloadAddressValidatorTest, SuggestionIncludesCountry) {
+TEST_F(PreloadAddressValidatorTest, MismatchedPostalCodeNoSuggestions) {
   AddressData address;
   address.region_code = "US";
+  address.administrative_area = "TX";
   address.postal_code = "90291";
 
   std::vector<AddressData> suggestions;
-  EXPECT_EQ(PreloadAddressValidator::SUCCESS,
-            validator_->GetSuggestions(address, POSTAL_CODE, 1, &suggestions));
-  ASSERT_EQ(1U, suggestions.size());
-  EXPECT_EQ("US", suggestions[0].region_code);
+  EXPECT_EQ(
+      PreloadAddressValidator::SUCCESS,
+      validator_->GetSuggestions(address, POSTAL_CODE, 999, &suggestions));
+  EXPECT_TRUE(suggestions.empty());
 }
 

[please use gerrit instead, 2014/06/05 22:22:49]

Add a test SuggestionsAreCleared!

[please use gerrit instead, 2014/06/09 23:28:17]

Done.

 TEST_F(PreloadAddressValidatorTest,
        SuggestOnlyForAdministrativeAreasAndPostalCode) {
   AddressData address;
   address.region_code = "US";
   address.administrative_area = "CA";
   address.locality = "Los Angeles";
   address.dependent_locality = "Venice";
   address.postal_code = "90291";
   address.sorting_code = "123";
   address.address_line.push_back("123 Main St");
@@ skipping 49 matching lines @@
 TEST_F(PreloadAddressValidatorTest, CanonicalizeJpAdminAreaLatinName) {
   validator_->LoadRules("JP", *loaded_);
   AddressData address;
   address.region_code = "JP";
   address.administrative_area = "tOKYo";
   EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
   EXPECT_EQ("TOKYO", address.administrative_area);
 }
 
 }  // namespace