Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: third_party/libaddressinput/chromium/chrome_storage_impl.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows compile. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "third_party/libaddressinput/chromium/chrome_storage_impl.h" 5 #include "third_party/libaddressinput/chromium/chrome_storage_impl.h"
6 6
7 #include "base/memory/scoped_ptr.h"
7 #include "base/prefs/writeable_pref_store.h" 8 #include "base/prefs/writeable_pref_store.h"
8 #include "base/values.h" 9 #include "base/values.h"
10 #include "third_party/libaddressinput/chromium/fallback_data_store.h"
9 11
10 namespace autofill { 12 namespace autofill {
11 13
12 ChromeStorageImpl::ChromeStorageImpl(WriteablePrefStore* store) 14 ChromeStorageImpl::ChromeStorageImpl(WriteablePrefStore* store)
13 : backing_store_(store), 15 : backing_store_(store),
14 scoped_observer_(this) { 16 scoped_observer_(this) {
15 scoped_observer_.Add(backing_store_); 17 scoped_observer_.Add(backing_store_);
16 } 18 }
17 19
18 ChromeStorageImpl::~ChromeStorageImpl() {} 20 ChromeStorageImpl::~ChromeStorageImpl() {}
19 21
20 void ChromeStorageImpl::Put(const std::string& key, 22 void ChromeStorageImpl::Put(const std::string& key, std::string* data) {
21 scoped_ptr<std::string> data) { 23 DCHECK(data);
24 scoped_ptr<std::string> owned_data(data);
22 scoped_ptr<base::StringValue> string_value( 25 scoped_ptr<base::StringValue> string_value(
23 new base::StringValue(std::string())); 26 new base::StringValue(std::string()));
24 string_value->GetString()->swap(*data); 27 string_value->GetString()->swap(*owned_data);
25 backing_store_->SetValue(key, string_value.release()); 28 backing_store_->SetValue(key, string_value.release());
26 } 29 }
27 30
28 void ChromeStorageImpl::Get( 31 void ChromeStorageImpl::Get(const std::string& key,
29 const std::string& key, 32 const Storage::Callback& data_ready) const {
30 scoped_ptr<Storage::Callback> data_ready) const {
31 // |Get()| should not be const, so this is just a thunk that fixes that. 33 // |Get()| should not be const, so this is just a thunk that fixes that.
32 const_cast<ChromeStorageImpl*>(this)->DoGet(key, data_ready.Pass()); 34 const_cast<ChromeStorageImpl*>(this)->DoGet(key, data_ready);
33 } 35 }
34 36
35 void ChromeStorageImpl::OnPrefValueChanged(const std::string& key) {} 37 void ChromeStorageImpl::OnPrefValueChanged(const std::string& key) {}
36 38
37 void ChromeStorageImpl::OnInitializationCompleted(bool succeeded) { 39 void ChromeStorageImpl::OnInitializationCompleted(bool succeeded) {
38 for (std::vector<Request*>::iterator iter = 40 for (std::vector<Request*>::iterator iter = outstanding_requests_.begin();
39 outstanding_requests_.begin();
40 iter != outstanding_requests_.end(); ++iter) { 41 iter != outstanding_requests_.end(); ++iter) {
41 DoGet((*iter)->key, (*iter)->callback.Pass()); 42 DoGet((*iter)->key, (*iter)->callback);
42 } 43 }
43 44
44 outstanding_requests_.clear(); 45 outstanding_requests_.clear();
45 } 46 }
46 47
47 void ChromeStorageImpl::DoGet( 48 void ChromeStorageImpl::DoGet(const std::string& key,
48 const std::string& key, 49 const Storage::Callback& data_ready) {
49 scoped_ptr<Storage::Callback> data_ready) {
50 if (!backing_store_->IsInitializationComplete()) { 50 if (!backing_store_->IsInitializationComplete()) {
51 outstanding_requests_.push_back( 51 outstanding_requests_.push_back(new Request(key, data_ready));
52 new Request(key, data_ready.Pass()));
53 return; 52 return;
54 } 53 }
55 54
56 const base::Value* value = NULL; 55 const base::Value* value = NULL;
57 const base::StringValue* string_value = NULL; 56 scoped_ptr<std::string> data(new std::string);
58 if (backing_store_->GetValue(key, &value) && 57 if (backing_store_->GetValue(key, &value) && value->GetAsString(data.get())) {
59 value->GetAsString(&string_value)) { 58 data_ready(true, key, data.release());
60 (*data_ready)(true, key, string_value->GetString()); 59 } else if (FallbackDataStore::Get(key, data.get())) {
60 data_ready(true, key, data.release());
61 } else { 61 } else {
62 (*data_ready)(false, key, std::string()); 62 data_ready(false, key, NULL);
63 } 63 }
64 } 64 }
65 65
66 ChromeStorageImpl::Request::Request(const std::string& key, 66 ChromeStorageImpl::Request::Request(const std::string& key,
67 scoped_ptr<Storage::Callback> callback) 67 const Callback& callback)
68 : key(key), 68 : key(key),
69 callback(callback.Pass()) {} 69 callback(callback) {}
70 70
71 } // namespace autofill 71 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698