Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

Issue 298863012: Use upstream libaddressinput in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/autofill_dialog_i18n_input.h" 5 #include "chrome/browser/ui/autofill/autofill_dialog_i18n_input.h"
6 6
7 #include "base/strings/string_split.h" 7 #include "base/strings/string_split.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "components/autofill/core/browser/address_i18n.h" 10 #include "components/autofill/core/browser/address_i18n.h"
11 #include "components/autofill/core/browser/autofill_profile.h" 11 #include "components/autofill/core/browser/autofill_profile.h"
12 #include "components/autofill/core/browser/credit_card.h" 12 #include "components/autofill/core/browser/credit_card.h"
13 #include "components/autofill/core/browser/field_types.h" 13 #include "components/autofill/core/browser/field_types.h"
14 #include "grit/components_strings.h" 14 #include "grit/components_strings.h"
15 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/addre ss_data.h" 15 #include "third_party/libaddressinput/chromium/has_all_required_fields.h"
16 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/addre ss_field.h" 16 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_da ta.h"
17 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/addre ss_ui.h" 17 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_fi eld.h"
18 #include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/addre ss_ui_component.h" 18 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui .h"
19 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui _component.h"
20 #include "third_party/libaddressinput/src/cpp/include/libaddressinput/localizati on.h"
19 #include "ui/base/l10n/l10n_util.h" 21 #include "ui/base/l10n/l10n_util.h"
20 22
21 namespace autofill { 23 namespace autofill {
22 namespace i18ninput { 24 namespace i18ninput {
23 25
24 namespace { 26 namespace {
25 27
26 using base::UTF16ToUTF8; 28 using base::UTF16ToUTF8;
27 using ::i18n::addressinput::AddressData;
28 using ::i18n::addressinput::AddressField; 29 using ::i18n::addressinput::AddressField;
29 using ::i18n::addressinput::AddressUiComponent; 30 using ::i18n::addressinput::AddressUiComponent;
31 using ::i18n::addressinput::Localization;
32
33 std::vector<AddressUiComponent> BuildComponents(const std::string& country_code,
34 std::string* language_code) {
35 Localization localization;
36 localization.SetGetter(
37 l10n_util::GetStringUTF8, g_browser_process->GetApplicationLocale());
38 std::string not_used;
39 return ::i18n::addressinput::BuildComponents(
40 country_code, localization,
41 language_code == NULL ? &not_used : language_code);
42 }
30 43
31 DetailInput::Length LengthFromHint(AddressUiComponent::LengthHint hint) { 44 DetailInput::Length LengthFromHint(AddressUiComponent::LengthHint hint) {
32 if (hint == AddressUiComponent::HINT_SHORT) 45 if (hint == AddressUiComponent::HINT_SHORT)
33 return DetailInput::SHORT; 46 return DetailInput::SHORT;
34 DCHECK_EQ(hint, AddressUiComponent::HINT_LONG); 47 DCHECK_EQ(hint, AddressUiComponent::HINT_LONG);
35 return DetailInput::LONG; 48 return DetailInput::LONG;
36 } 49 }
37 50
38 } // namespace 51 } // namespace
39 52
40 void BuildAddressInputs(common::AddressType address_type, 53 void BuildAddressInputs(common::AddressType address_type,
41 const std::string& country_code, 54 const std::string& country_code,
42 DetailInputs* inputs, 55 DetailInputs* inputs,
43 std::string* language_code) { 56 std::string* language_code) {
44 std::vector<AddressUiComponent> components( 57 const std::vector<AddressUiComponent>& components(
45 ::i18n::addressinput::BuildComponents( 58 BuildComponents(country_code, language_code));
46 country_code, g_browser_process->GetApplicationLocale(),
47 language_code));
48 59
49 const bool billing = address_type == common::ADDRESS_TYPE_BILLING; 60 const bool billing = address_type == common::ADDRESS_TYPE_BILLING;
50 61
51 for (size_t i = 0; i < components.size(); ++i) { 62 for (size_t i = 0; i < components.size(); ++i) {
52 const AddressUiComponent& component = components[i]; 63 const AddressUiComponent& component = components[i];
53 if (component.field == ::i18n::addressinput::ORGANIZATION) {
54 // TODO(dbeam): figure out when we actually need this.
55 continue;
56 }
57
58 ServerFieldType server_type = TypeForField(component.field, address_type); 64 ServerFieldType server_type = TypeForField(component.field, address_type);
59 DetailInput::Length length = LengthFromHint(component.length_hint); 65 DetailInput::Length length = LengthFromHint(component.length_hint);
60 base::string16 placeholder = l10n_util::GetStringUTF16(component.name_id); 66 base::string16 placeholder = base::UTF8ToUTF16(component.name);
61 DetailInput input = { length, server_type, placeholder }; 67 DetailInput input = { length, server_type, placeholder };
62 inputs->push_back(input); 68 inputs->push_back(input);
63 } 69 }
64 70
65 ServerFieldType server_type = 71 ServerFieldType server_type =
66 billing ? ADDRESS_BILLING_COUNTRY : ADDRESS_HOME_COUNTRY; 72 billing ? ADDRESS_BILLING_COUNTRY : ADDRESS_HOME_COUNTRY;
67 base::string16 placeholder_text = 73 base::string16 placeholder_text =
68 l10n_util::GetStringUTF16(IDS_AUTOFILL_FIELD_LABEL_COUNTRY); 74 l10n_util::GetStringUTF16(IDS_AUTOFILL_FIELD_LABEL_COUNTRY);
69 DetailInput input = { DetailInput::LONG, server_type, placeholder_text }; 75 DetailInput input = { DetailInput::LONG, server_type, placeholder_text };
70 inputs->push_back(input); 76 inputs->push_back(input);
(...skipping 15 matching lines...) Expand all
86 } 92 }
87 93
88 return true; 94 return true;
89 } 95 }
90 96
91 bool AddressHasCompleteAndVerifiedData(const AutofillProfile& profile, 97 bool AddressHasCompleteAndVerifiedData(const AutofillProfile& profile,
92 const std::string& app_locale) { 98 const std::string& app_locale) {
93 if (!profile.IsVerified()) 99 if (!profile.IsVerified())
94 return false; 100 return false;
95 101
96 if (!i18n::CreateAddressDataFromAutofillProfile(profile, app_locale)-> 102 if (!addressinput::HasAllRequiredFields(
97 HasAllRequiredFields()) { 103 *i18n::CreateAddressDataFromAutofillProfile(profile, app_locale))) {
98 return false; 104 return false;
99 } 105 }
100 106
101 const ServerFieldType more_required_fields[] = { 107 const ServerFieldType more_required_fields[] = {
102 NAME_FULL, 108 NAME_FULL,
103 PHONE_HOME_WHOLE_NUMBER 109 PHONE_HOME_WHOLE_NUMBER
104 }; 110 };
105 111
106 for (size_t i = 0; i < arraysize(more_required_fields); ++i) { 112 for (size_t i = 0; i < arraysize(more_required_fields); ++i) {
107 if (profile.GetRawInfo(more_required_fields[i]).empty()) 113 if (profile.GetRawInfo(more_required_fields[i]).empty())
(...skipping 18 matching lines...) Expand all
126 ADDRESS_HOME_DEPENDENT_LOCALITY; 132 ADDRESS_HOME_DEPENDENT_LOCALITY;
127 case ::i18n::addressinput::POSTAL_CODE: 133 case ::i18n::addressinput::POSTAL_CODE:
128 return billing ? ADDRESS_BILLING_ZIP : ADDRESS_HOME_ZIP; 134 return billing ? ADDRESS_BILLING_ZIP : ADDRESS_HOME_ZIP;
129 case ::i18n::addressinput::SORTING_CODE: 135 case ::i18n::addressinput::SORTING_CODE:
130 return billing ? ADDRESS_BILLING_SORTING_CODE : ADDRESS_HOME_SORTING_CODE; 136 return billing ? ADDRESS_BILLING_SORTING_CODE : ADDRESS_HOME_SORTING_CODE;
131 case ::i18n::addressinput::STREET_ADDRESS: 137 case ::i18n::addressinput::STREET_ADDRESS:
132 return billing ? ADDRESS_BILLING_STREET_ADDRESS : 138 return billing ? ADDRESS_BILLING_STREET_ADDRESS :
133 ADDRESS_HOME_STREET_ADDRESS; 139 ADDRESS_HOME_STREET_ADDRESS;
134 case ::i18n::addressinput::RECIPIENT: 140 case ::i18n::addressinput::RECIPIENT:
135 return billing ? NAME_BILLING_FULL : NAME_FULL; 141 return billing ? NAME_BILLING_FULL : NAME_FULL;
136 case ::i18n::addressinput::ORGANIZATION:
137 return COMPANY_NAME;
138 } 142 }
139 NOTREACHED(); 143 NOTREACHED();
140 return UNKNOWN_TYPE; 144 return UNKNOWN_TYPE;
141 } 145 }
142 146
143 bool FieldForType(ServerFieldType server_type, 147 bool FieldForType(ServerFieldType server_type, AddressField* field) {
144 ::i18n::addressinput::AddressField* field) {
145 switch (server_type) { 148 switch (server_type) {
146 case ADDRESS_BILLING_COUNTRY: 149 case ADDRESS_BILLING_COUNTRY:
147 case ADDRESS_HOME_COUNTRY: 150 case ADDRESS_HOME_COUNTRY:
148 if (field) 151 if (field)
149 *field = ::i18n::addressinput::COUNTRY; 152 *field = ::i18n::addressinput::COUNTRY;
150 return true; 153 return true;
151 case ADDRESS_BILLING_STATE: 154 case ADDRESS_BILLING_STATE:
152 case ADDRESS_HOME_STATE: 155 case ADDRESS_HOME_STATE:
153 if (field) 156 if (field)
154 *field = ::i18n::addressinput::ADMIN_AREA; 157 *field = ::i18n::addressinput::ADMIN_AREA;
(...skipping 20 matching lines...) Expand all
175 return true; 178 return true;
176 case ADDRESS_BILLING_STREET_ADDRESS: 179 case ADDRESS_BILLING_STREET_ADDRESS:
177 case ADDRESS_BILLING_LINE1: 180 case ADDRESS_BILLING_LINE1:
178 case ADDRESS_BILLING_LINE2: 181 case ADDRESS_BILLING_LINE2:
179 case ADDRESS_HOME_STREET_ADDRESS: 182 case ADDRESS_HOME_STREET_ADDRESS:
180 case ADDRESS_HOME_LINE1: 183 case ADDRESS_HOME_LINE1:
181 case ADDRESS_HOME_LINE2: 184 case ADDRESS_HOME_LINE2:
182 if (field) 185 if (field)
183 *field = ::i18n::addressinput::STREET_ADDRESS; 186 *field = ::i18n::addressinput::STREET_ADDRESS;
184 return true; 187 return true;
185 case COMPANY_NAME:
186 if (field)
187 *field = ::i18n::addressinput::ORGANIZATION;
188 return true;
189 case NAME_BILLING_FULL: 188 case NAME_BILLING_FULL:
190 case NAME_FULL: 189 case NAME_FULL:
191 if (field) 190 if (field)
192 *field = ::i18n::addressinput::RECIPIENT; 191 *field = ::i18n::addressinput::RECIPIENT;
193 return true; 192 return true;
194 default: 193 default:
195 return false; 194 return false;
196 } 195 }
197 } 196 }
198 197
199 bool CountryIsFullySupported(const std::string& country_code) { 198 bool CountryIsFullySupported(const std::string& country_code) {
200 DCHECK_EQ(2U, country_code.size()); 199 DCHECK_EQ(2U, country_code.size());
201 std::vector< ::i18n::addressinput::AddressUiComponent> components = 200 const std::vector<AddressUiComponent>& components(
202 ::i18n::addressinput::BuildComponents( 201 BuildComponents(country_code, NULL));
203 country_code, g_browser_process->GetApplicationLocale(), NULL);
204 for (size_t i = 0; i < components.size(); ++i) { 202 for (size_t i = 0; i < components.size(); ++i) {
205 if (components[i].field == ::i18n::addressinput::DEPENDENT_LOCALITY) 203 if (components[i].field == ::i18n::addressinput::DEPENDENT_LOCALITY)
206 return false; 204 return false;
207 } 205 }
208 return true; 206 return true;
209 } 207 }
210 208
211 } // namespace i18ninput 209 } // namespace i18ninput
212 } // namespace autofill 210 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698